From: Nishanth Menon <nm@ti.com>
To: Pavel Machek <pavel@ucw.cz>, linux-omap@vger.kernel.org
Cc: edubezval@gmail.com, rui.zhang@intel.com,
linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org
Subject: Re: [PATCH] cleanup ti-soc-thermal
Date: Sat, 03 Jan 2015 12:57:04 -0600 [thread overview]
Message-ID: <54A83B80.1020508@ti.com> (raw)
In-Reply-To: <20150103185130.GA5950@amd>
On 01/03/2015 12:51 PM, Pavel Machek wrote:
> On Sat 2015-01-03 11:48:04, Nishanth Menon wrote:
>> On 12:19-20150103, Pavel Machek wrote:
>>> Simplify code by removing goto's where they point to simple return.
>>>
>>> Avoid confusing |= on error values.
>>
>> Please split these up into chunks of related changes. there is white
>> space and quiet a few other changes all mixed in.
>
> Do you believe that the patch is too big to be understood? I don't
> think it is.
>
> It is four screens, and it is pretty obvious it does not change any
> code.
It basic patch generation stuff - where you are being nice to the
reviewer. When you are doing functional changes, at least drop out or at
the very least mention that there are white space changes in your patch
submission.
I dont care too much to review stuff where I have to look at multiple
changes in a single patch - trivial or not. Sorry.. just a waste of my time.
--
Regards,
Nishanth Menon
next prev parent reply other threads:[~2015-01-03 18:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-03 11:19 [PATCH] cleanup ti-soc-thermal Pavel Machek
2015-01-03 17:48 ` Nishanth Menon
2015-01-03 18:51 ` Pavel Machek
2015-01-03 18:57 ` Nishanth Menon [this message]
2015-01-03 19:02 ` Pavel Machek
2015-01-03 18:53 ` Pavel Machek
2015-01-18 20:17 ` [PATCHv2] " Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54A83B80.1020508@ti.com \
--to=nm@ti.com \
--cc=edubezval@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox