From: Greg Ungerer <gerg@uclinux.org>
To: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>,
Geert Uytterhoeven <geert@linux-m68k.org>
Cc: linux-m68k@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arch: m68k: 68360: config: Remove unused function
Date: Mon, 05 Jan 2015 10:29:35 +1000 [thread overview]
Message-ID: <54A9DAEF.1020008@uclinux.org> (raw)
In-Reply-To: <1420232714-3989-1-git-send-email-rickard_strandqvist@spectrumdigital.se>
Hi Rickard,
On 03/01/15 07:05, Rickard Strandqvist wrote:
> Remove the function BSP_set_clock_mmss() that is not used anywhere.
>
> This was partially found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Thanks, I'll add it to the m68knommu git tree.
Regards
Greg
> ---
> arch/m68k/68360/config.c | 13 -------------
> 1 file changed, 13 deletions(-)
>
> diff --git a/arch/m68k/68360/config.c b/arch/m68k/68360/config.c
> index 17ec416..fd1f948 100644
> --- a/arch/m68k/68360/config.c
> +++ b/arch/m68k/68360/config.c
> @@ -106,19 +106,6 @@ void hw_timer_init(irq_handler_t handler)
> pquicc->timer_tgcr = tgcr_save;
> }
>
> -int BSP_set_clock_mmss(unsigned long nowtime)
> -{
> -#if 0
> - short real_seconds = nowtime % 60, real_minutes = (nowtime / 60) % 60;
> -
> - tod->second1 = real_seconds / 10;
> - tod->second2 = real_seconds % 10;
> - tod->minute1 = real_minutes / 10;
> - tod->minute2 = real_minutes % 10;
> -#endif
> - return 0;
> -}
> -
> void BSP_reset (void)
> {
> local_irq_disable();
>
prev parent reply other threads:[~2015-01-05 0:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-02 21:05 [PATCH] arch: m68k: 68360: config: Remove unused function Rickard Strandqvist
2015-01-05 0:29 ` Greg Ungerer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54A9DAEF.1020008@uclinux.org \
--to=gerg@uclinux.org \
--cc=geert@linux-m68k.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-m68k@vger.kernel.org \
--cc=rickard_strandqvist@spectrumdigital.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).