From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753679AbbAEKO5 (ORCPT ); Mon, 5 Jan 2015 05:14:57 -0500 Received: from mail-gw1-out.broadcom.com ([216.31.210.62]:6728 "EHLO mail-gw1-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752854AbbAEKO4 (ORCPT ); Mon, 5 Jan 2015 05:14:56 -0500 X-IronPort-AV: E=Sophos;i="5.07,698,1413270000"; d="scan'208";a="54294176" Message-ID: <54AA641C.7050307@broadcom.com> Date: Mon, 5 Jan 2015 11:14:52 +0100 From: Arend van Spriel User-Agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); en-US; rv:1.9.2.24) Gecko/20111103 Lightning/1.0b2 Thunderbird/3.1.16 MIME-Version: 1.0 To: Paul Bolle CC: Linus Torvalds , Marcel Holtmann , Stanislav Yakovlev , "Kalle Valo" , Jiri Kosina , linux-wireless , Network Development , Linux Kernel Mailing List Subject: Re: [PATCH] Revert "ipw2200: select CFG80211_WEXT" References: <1420297188.2397.3.camel@tiscali.nl> <1420324124.9624.60.camel@x220> In-Reply-To: <1420324124.9624.60.camel@x220> Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/03/15 23:28, Paul Bolle wrote: > On Sat, 2015-01-03 at 10:07 -0800, Linus Torvalds wrote: >> On Sat, Jan 3, 2015 at 10:02 AM, Marcel Holtmann wrote: >>> >>> why would you revert this? It is obviously the correct change to actually select CFG80211_WEXT. >> >> I don't know about obvious, but yeah, I think the select in this case >> is actually the better idea anyway. > > Obviously it wasn't obvious to me! > > My reasoning was that the "ipw2200: select CFG80211_WEXT" commit was > _solely_ a workaround for the breakage introduced by that other patch. > And since that one is now reverted the workaround wasn't needed anymore. > > Besied, I thought we try to avoid select-ing symbols that can also be > set manually. As that makes it more likely to trigger circular > dependency problems in the kconfig tools, doesn't it? > >> We could make the CFG80211_WEXT help message be very negative so that >> people aren't encouraged to select it even if they can, but then if >> they need the ipw driver it gets selected because of that. Because the >> ipw driver is probably the more important of the two if you just >> happen to have old hardware but are upgrading yout software (and >> anybody who recompiles their own kernel is obviously doing the >> latter). > > Side note: am I correct in thinking that there's some successor to > CFG80211_WEXT and that the ipw2200 driver could, at least in theory, be > ported to that successor? (ipw2200 hardware appears to be a bit old, so > probably no one would care enough to actually do that.) > net/wireless/kconfig doesn't mention anything like that, so probably I'm > just confused. ipw2200 is a WEXT driver using some wext functionality (and struct wiphy) provided by cfg80211 hence it needs CFG80211_WEXT. I guess that is what makes it confusing. Regards, Arend > Paul Bolle > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/