* [PATCH] fbdev: geocode: remove unneeded NULL check
@ 2014-12-31 6:55 Sudip Mukherjee
2015-01-05 12:57 ` Tomi Valkeinen
0 siblings, 1 reply; 6+ messages in thread
From: Sudip Mukherjee @ 2014-12-31 6:55 UTC (permalink / raw)
To: Jean-Christophe Plagniol-Villard, Tomi Valkeinen
Cc: Sudip Mukherjee, linux-geode, linux-fbdev, linux-kernel
the check for info is not required as we are checking it immediately
after gx1fb_init_fbinfo() and returnig -ENOMEM if it is NULL.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
drivers/video/fbdev/geode/gx1fb_core.c | 6 ++----
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/video/fbdev/geode/gx1fb_core.c b/drivers/video/fbdev/geode/gx1fb_core.c
index 2794ba1..9bee874 100644
--- a/drivers/video/fbdev/geode/gx1fb_core.c
+++ b/drivers/video/fbdev/geode/gx1fb_core.c
@@ -374,10 +374,8 @@ static int gx1fb_probe(struct pci_dev *pdev, const struct pci_device_id *id)
release_mem_region(gx1_gx_base() + 0x8300, 0x100);
}
- if (info) {
- fb_dealloc_cmap(&info->cmap);
- framebuffer_release(info);
- }
+ fb_dealloc_cmap(&info->cmap);
+ framebuffer_release(info);
return ret;
}
--
1.8.1.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] fbdev: geocode: remove unneeded NULL check
2014-12-31 6:55 [PATCH] fbdev: geocode: remove unneeded NULL check Sudip Mukherjee
@ 2015-01-05 12:57 ` Tomi Valkeinen
0 siblings, 0 replies; 6+ messages in thread
From: Tomi Valkeinen @ 2015-01-05 12:57 UTC (permalink / raw)
To: Sudip Mukherjee, Jean-Christophe Plagniol-Villard
Cc: linux-geode, linux-fbdev, linux-kernel
[-- Attachment #1: Type: text/plain, Size: 987 bytes --]
On 31/12/14 08:55, Sudip Mukherjee wrote:
> the check for info is not required as we are checking it immediately
> after gx1fb_init_fbinfo() and returnig -ENOMEM if it is NULL.
>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
> drivers/video/fbdev/geode/gx1fb_core.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/video/fbdev/geode/gx1fb_core.c b/drivers/video/fbdev/geode/gx1fb_core.c
> index 2794ba1..9bee874 100644
> --- a/drivers/video/fbdev/geode/gx1fb_core.c
> +++ b/drivers/video/fbdev/geode/gx1fb_core.c
> @@ -374,10 +374,8 @@ static int gx1fb_probe(struct pci_dev *pdev, const struct pci_device_id *id)
> release_mem_region(gx1_gx_base() + 0x8300, 0x100);
> }
>
> - if (info) {
> - fb_dealloc_cmap(&info->cmap);
> - framebuffer_release(info);
> - }
> + fb_dealloc_cmap(&info->cmap);
> + framebuffer_release(info);
>
> return ret;
> }
>
Thanks, queued for 3.20.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] fbdev: geocode: remove unneeded NULL check
2015-01-06 12:45 [PATCH] video: vt8500lcdfb: remove unneeded continue Sudip Mukherjee
@ 2015-01-06 12:45 ` Sudip Mukherjee
2015-01-13 11:31 ` Tomi Valkeinen
0 siblings, 1 reply; 6+ messages in thread
From: Sudip Mukherjee @ 2015-01-06 12:45 UTC (permalink / raw)
To: Jean-Christophe Plagniol-Villard, Tomi Valkeinen
Cc: Sudip Mukherjee, linux-geode, linux-fbdev, linux-kernel
the check for info is not required as we are checking it immediately
after gxfb_init_fbinfo() and lxfb_init_fbinfo() and returnig -ENOMEM
if it is NULL.
Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
---
Hi Tomi,
This patch is similar to my last patch which you have already queued
for 3.20. if you can revert that then i can send you a single patch
with all these three changes together.
drivers/video/fbdev/geode/gxfb_core.c | 6 ++----
drivers/video/fbdev/geode/lxfb_core.c | 6 ++----
2 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/video/fbdev/geode/gxfb_core.c b/drivers/video/fbdev/geode/gxfb_core.c
index 1790f14..124d7c7 100644
--- a/drivers/video/fbdev/geode/gxfb_core.c
+++ b/drivers/video/fbdev/geode/gxfb_core.c
@@ -444,10 +444,8 @@ static int gxfb_probe(struct pci_dev *pdev, const struct pci_device_id *id)
pci_release_region(pdev, 1);
}
- if (info) {
- fb_dealloc_cmap(&info->cmap);
- framebuffer_release(info);
- }
+ fb_dealloc_cmap(&info->cmap);
+ framebuffer_release(info);
return ret;
}
diff --git a/drivers/video/fbdev/geode/lxfb_core.c b/drivers/video/fbdev/geode/lxfb_core.c
index 9e1d19d..138da6c 100644
--- a/drivers/video/fbdev/geode/lxfb_core.c
+++ b/drivers/video/fbdev/geode/lxfb_core.c
@@ -577,10 +577,8 @@ err:
pci_release_region(pdev, 3);
}
- if (info) {
- fb_dealloc_cmap(&info->cmap);
- framebuffer_release(info);
- }
+ fb_dealloc_cmap(&info->cmap);
+ framebuffer_release(info);
return ret;
}
--
1.8.1.2
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] fbdev: geocode: remove unneeded NULL check
2015-01-06 12:45 ` [PATCH] fbdev: geocode: remove unneeded NULL check Sudip Mukherjee
@ 2015-01-13 11:31 ` Tomi Valkeinen
2015-02-01 5:05 ` deloptes
0 siblings, 1 reply; 6+ messages in thread
From: Tomi Valkeinen @ 2015-01-13 11:31 UTC (permalink / raw)
To: Sudip Mukherjee
Cc: Jean-Christophe Plagniol-Villard, linux-geode, linux-fbdev,
linux-kernel
[-- Attachment #1: Type: text/plain, Size: 555 bytes --]
On 06/01/15 14:45, Sudip Mukherjee wrote:
> the check for info is not required as we are checking it immediately
> after gxfb_init_fbinfo() and lxfb_init_fbinfo() and returnig -ENOMEM
> if it is NULL.
>
> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> ---
> Hi Tomi,
> This patch is similar to my last patch which you have already queued
> for 3.20. if you can revert that then i can send you a single patch
> with all these three changes together.
No need for that, two separate patches is fine. So queued for 3.20.
Tomi
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] fbdev: geocode: remove unneeded NULL check
2015-01-13 11:31 ` Tomi Valkeinen
@ 2015-02-01 5:05 ` deloptes
2015-02-02 15:13 ` One Thousand Gnomes
0 siblings, 1 reply; 6+ messages in thread
From: deloptes @ 2015-02-01 5:05 UTC (permalink / raw)
To: linux-kernel; +Cc: linux-geode
Tomi Valkeinen wrote:
> On 06/01/15 14:45, Sudip Mukherjee wrote:
>> the check for info is not required as we are checking it immediately
>> after gxfb_init_fbinfo() and lxfb_init_fbinfo() and returnig -ENOMEM
>> if it is NULL.
>>
>> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
>> ---
>> Hi Tomi,
>> This patch is similar to my last patch which you have already queued
>> for 3.20. if you can revert that then i can send you a single patch
>> with all these three changes together.
>
> No need for that, two separate patches is fine. So queued for 3.20.
>
> Tomi
Hi sorry for off topic question, but how do you run 3.20 on geode ?
I was not able to boot anything since 2.27 as initrd (I guess udev )
corrupts (I guess memory something) and boot hangs.
One suggested to bisect but no one explained how.
I would be glad to get some hint on how to run kernel with udev support on
geode (means >= 2.27)
thanks
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] fbdev: geocode: remove unneeded NULL check
2015-02-01 5:05 ` deloptes
@ 2015-02-02 15:13 ` One Thousand Gnomes
0 siblings, 0 replies; 6+ messages in thread
From: One Thousand Gnomes @ 2015-02-02 15:13 UTC (permalink / raw)
To: deloptes; +Cc: linux-kernel, linux-geode
On Sun, 01 Feb 2015 06:05:04 +0100
deloptes <deloptes@yahoo.com> wrote:
> Tomi Valkeinen wrote:
>
> > On 06/01/15 14:45, Sudip Mukherjee wrote:
> >> the check for info is not required as we are checking it immediately
> >> after gxfb_init_fbinfo() and lxfb_init_fbinfo() and returnig -ENOMEM
> >> if it is NULL.
> >>
> >> Signed-off-by: Sudip Mukherjee <sudip@vectorindia.org>
> >> ---
> >> Hi Tomi,
> >> This patch is similar to my last patch which you have already queued
> >> for 3.20. if you can revert that then i can send you a single patch
> >> with all these three changes together.
> >
> > No need for that, two separate patches is fine. So queued for 3.20.
> >
> > Tomi
>
> Hi sorry for off topic question, but how do you run 3.20 on geode ?
> I was not able to boot anything since 2.27 as initrd (I guess udev )
> corrupts (I guess memory something) and boot hangs.
> One suggested to bisect but no one explained how.
> I would be glad to get some hint on how to run kernel with udev support on
> geode (means >= 2.27)
Tinycore has certainly been reported to run on Geode boxes as of 3.x
kernel series. It might be worth trying a tinycore build on the device
just to see how far it gets on your hardware.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2015-02-02 15:14 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-31 6:55 [PATCH] fbdev: geocode: remove unneeded NULL check Sudip Mukherjee
2015-01-05 12:57 ` Tomi Valkeinen
-- strict thread matches above, loose matches on Subject: below --
2015-01-06 12:45 [PATCH] video: vt8500lcdfb: remove unneeded continue Sudip Mukherjee
2015-01-06 12:45 ` [PATCH] fbdev: geocode: remove unneeded NULL check Sudip Mukherjee
2015-01-13 11:31 ` Tomi Valkeinen
2015-02-01 5:05 ` deloptes
2015-02-02 15:13 ` One Thousand Gnomes
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox