From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754070AbbAEN6s (ORCPT <rfc822;w@1wt.eu>);
	Mon, 5 Jan 2015 08:58:48 -0500
Received: from mx1.redhat.com ([209.132.183.28]:40729 "EHLO mx1.redhat.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753834AbbAEN6r (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 5 Jan 2015 08:58:47 -0500
Message-ID: <54AA9884.5070202@redhat.com>
Date: Mon, 05 Jan 2015 14:58:28 +0100
From: Laszlo Ersek <lersek@redhat.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0
MIME-Version: 1.0
To: David Vrabel <david.vrabel@citrix.com>,
        Vitaly Kuznetsov <vkuznets@redhat.com>
CC: x86@kernel.org, Andrew Jones <drjones@redhat.com>,
        linux-kernel@vger.kernel.org, Ingo Molnar <mingo@redhat.com>,
        "H. Peter Anvin" <hpa@zytor.com>, xen-devel@lists.xenproject.org,
        Boris Ostrovsky <boris.ostrovsky@oracle.com>,
        Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [Xen-devel] [PATCH] x86/xen: avoid freeing static 'name' when
 kasprintf() fails
References: <1420463205-19249-1-git-send-email-vkuznets@redhat.com> <54AA8F7C.6000006@citrix.com>
In-Reply-To: <54AA8F7C.6000006@citrix.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 01/05/15 14:19, David Vrabel wrote:
> On 05/01/15 13:06, Vitaly Kuznetsov wrote:
>> In case kasprintf() fails in xen_setup_timer() we assign name to the static
>> string "<timer kasprintf failed>". We, however, don't check that fact before
>> issuing kfree() in xen_teardown_timer(), kernel is supposed to crash with
>> 'kernel BUG at mm/slub.c:3341!'
>>
>> Solve the issue by making name a fixed length string inside struct
>> xen_clock_event_device. 16 bytes should be enough.
>>
>> The issue was discovered by Laszlo Ersek.
> 
> Add Reported-by: Laszlo ... tag perhaps?
> 
>> --- a/arch/x86/xen/time.c
>> +++ b/arch/x86/xen/time.c
>> @@ -391,7 +391,7 @@ static const struct clock_event_device *xen_clockevent =
>>  
>>  struct xen_clock_event_device {
>>  	struct clock_event_device evt;
>> -	char *name;
>> +	char name[16];
>>  };
>>  static DEFINE_PER_CPU(struct xen_clock_event_device, xen_clock_events) = { .evt.irq = -1 };
>>  
>> @@ -420,14 +420,11 @@ void xen_teardown_timer(int cpu)
>>  	if (evt->irq >= 0) {
>>  		unbind_from_irqhandler(evt->irq, NULL);
>>  		evt->irq = -1;
>> -		kfree(per_cpu(xen_clock_events, cpu).name);
>> -		per_cpu(xen_clock_events, cpu).name = NULL;
>>  	}
>>  }
>>  
>>  void xen_setup_timer(int cpu)
>>  {
>> -	char *name;
>>  	struct clock_event_device *evt;
> 
> struct xen_clock_event_device *xevt = ...;
> 
>>  	int irq;
>>  
>> @@ -438,21 +435,19 @@ void xen_setup_timer(int cpu)
>>  
>>  	printk(KERN_INFO "installing Xen timer for CPU %d\n", cpu);
>>  
>> -	name = kasprintf(GFP_KERNEL, "timer%d", cpu);
>> -	if (!name)
>> -		name = "<timer kasprintf failed>";
>> +	snprintf(per_cpu(xen_clock_events, cpu).name, 16, "timer%d", cpu);
> 
> Use sizeof(xevt->name) here.

Yes, I wanted to recommend sizeof too.

Also the "standard" Reported-by tag would be nice.

Thanks!
Laszlo