From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754152AbbAEOWv (ORCPT <rfc822;w@1wt.eu>);
	Mon, 5 Jan 2015 09:22:51 -0500
Received: from cantor2.suse.de ([195.135.220.15]:54174 "EHLO mx2.suse.de"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1753248AbbAEOWs (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 5 Jan 2015 09:22:48 -0500
Message-ID: <54AA9E09.7040308@suse.cz>
Date: Mon, 05 Jan 2015 15:22:01 +0100
From: Vlastimil Babka <vbabka@suse.cz>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0
MIME-Version: 1.0
To: Andrew Morton <akpm@linux-foundation.org>
CC: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
        Linus Torvalds <torvalds@linux-foundation.org>,
        "Aneesh Kumar K.V" <aneesh.kumar@linux.vnet.ibm.com>,
        David Rientjes <rientjes@google.com>,
        Johannes Weiner <hannes@cmpxchg.org>,
        Joonsoo Kim <iamjoonsoo.kim@lge.com>,
        "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com>,
        Mel Gorman <mgorman@suse.de>, Michal Hocko <mhocko@suse.cz>,
        Minchan Kim <minchan@kernel.org>, Rik van Riel <riel@redhat.com>,
        Zhang Yanfei <zhangyanfei@cn.fujitsu.com>
Subject: Re: [PATCH V3 0/4] Reducing parameters of alloc_pages* family of
 functions
References: <1418400805-4661-1-git-send-email-vbabka@suse.cz> <20141218132619.4e6b349d0aa1744c41f985c7@linux-foundation.org>
In-Reply-To: <20141218132619.4e6b349d0aa1744c41f985c7@linux-foundation.org>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 12/18/2014 10:26 PM, Andrew Morton wrote:
> On Fri, 12 Dec 2014 17:13:21 +0100 Vlastimil Babka <vbabka@suse.cz> wrote:
> 
>> Vlastimil Babka (4):
>>   mm: set page->pfmemalloc in prep_new_page()
>>   mm, page_alloc: reduce number of alloc_pages* functions' parameters
>>   mm: reduce try_to_compact_pages parameters
>>   mm: microoptimize zonelist operations
> 
> That all looks pretty straightforward.  It would be nice to have a
> summary of the code-size and stack-usage changes for the whole
> patchset.

OK

> Can we move `struct alloc_context' into mm/internal.h?

Only if we moved also try_to_compact_pages() declaration from
include/linux/compaction.h to mm/internal.h. I guess it's not a bad idea, as
it's a MM-only function and mm/internal.h already contains compaction stuff.

> I pity the poor schmuck who has to maintain this patchset for 2 months.
> [2/4] already throws a large pile of rejects against page_alloc.c so
> can you please refresh/retest/resend?

Right :)

Vlastimil