From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754642AbbAEXKo (ORCPT ); Mon, 5 Jan 2015 18:10:44 -0500 Received: from mga02.intel.com ([134.134.136.20]:31760 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753226AbbAEXKn (ORCPT ); Mon, 5 Jan 2015 18:10:43 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.07,702,1413270000"; d="scan'208";a="632893388" Message-ID: <54AB19EC.4020401@linux.intel.com> Date: Mon, 05 Jan 2015 15:10:36 -0800 From: Dave Hansen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Andy Lutomirski CC: Andi Kleen , "linux-kernel@vger.kernel.org" , X86 ML , Thomas Gleixner Subject: Re: [PATCH 3.19 3/3] x86, mpx: Change the MPX enable/disable API to arch_prctl References: <54A64E6D.1020304@linux.intel.com> <87mw5x0xjz.fsf@tassilo.jf.intel.com> <54AAFFA3.6000901@linux.intel.com> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/05/2015 03:04 PM, Andy Lutomirski wrote: >> > Yeah, I'd _really_ prefer not to change it. The code is in a gcc >> > branch, but is getting pulled in to the 5.0 release. We've got >> > *absolutely* no shortage of prctl numbers. > We do, however, have a severe shortage of sanity in the prctl implementation. > > Anyway, if it's actually a problem to change it, I have no real > problem keeping it, but I think we *really* need to validate the rest > of the arguments at the very least. Do you mean just adding a pair of if (arg2 || arg3 || arg4 || arg5) return -EINVAL; checks? That's perfectly fine with me. I'm happy to queue up a patch to do just that if that's what you're going for.