From: Ian Abbott <abbotti@mev.co.uk>
To: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Piotr Kubus <p.t.kubus@gmail.com>
Cc: Konrad Zapalowicz <bergo.torino@gmail.com>,
gregkh@linuxfoundation.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Staging: comedi: dmm32at: Fixed a code indent issue
Date: Tue, 06 Jan 2015 10:08:37 +0000 [thread overview]
Message-ID: <54ABB425.1080207@mev.co.uk> (raw)
In-Reply-To: <20150106060226.GA4285@sudip-PC>
On 06/01/15 06:02, Sudip Mukherjee wrote:
> On Mon, Jan 05, 2015 at 08:24:06PM +0100, Piotr Kubus wrote:
>> On Sun, Jan 04, 2015 at 11:31:29PM +0100, Konrad Zapalowicz wrote:
>>> On 01/04, Piotr Kubus wrote:
>>>> This is a patch to the dmm32at.c file that fixes up a code indent error found by the checkpatch.pl tool.
>>>
>>> Nice however improve your commit message. The rule is that the lines
>>> should wrap at 72nd column except for quoted material such as compiler
>>> output, etc...
>>>
>>> The 72-character columns are important for allowing quoting and they
>>> play nicely with standard indentation from git log.
>>
>> Hey,
>>
>> I couldn't find that rule in Kernel documentation. Besides there were no
>> complaints from checkpatch.pl tool.
>
> Please check SubmittingPatches in Documentation. It says:
> 'the "summary" must be no more than 70-75 characters'
In this case, it's not the "summary" that's at issue, it's the body of
the commit message, as Konrad mentioned above.
--
-=( Ian Abbott @ MEV Ltd. E-mail: <abbotti@mev.co.uk> )=-
-=( Web: http://www.mev.co.uk/ )=-
next prev parent reply other threads:[~2015-01-06 10:08 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-04 15:22 [PATCH] Staging: comedi: dmm32at: Fixed a code indent issue Piotr Kubus
2015-01-04 22:31 ` Konrad Zapalowicz
2015-01-05 19:24 ` Piotr Kubus
2015-01-06 6:02 ` Sudip Mukherjee
2015-01-06 10:08 ` Ian Abbott [this message]
2015-01-06 10:27 ` Sudip Mukherjee
2015-01-06 13:33 ` Konrad Zapalowicz
2015-01-06 13:50 ` Sudip Mukherjee
2015-01-06 10:06 ` Dan Carpenter
2015-01-10 0:59 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54ABB425.1080207@mev.co.uk \
--to=abbotti@mev.co.uk \
--cc=bergo.torino@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.t.kubus@gmail.com \
--cc=sudipm.mukherjee@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox