From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1755662AbbAFQtq (ORCPT <rfc822;w@1wt.eu>);
	Tue, 6 Jan 2015 11:49:46 -0500
Received: from mail-qg0-f42.google.com ([209.85.192.42]:45852 "EHLO
	mail-qg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753325AbbAFQto (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 6 Jan 2015 11:49:44 -0500
Message-ID: <54AC1225.7080804@hurleysoftware.com>
Date: Tue, 06 Jan 2015 11:49:41 -0500
From: Peter Hurley <peter@hurleysoftware.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0
MIME-Version: 1.0
To: Jiri Slaby <jslaby@suse.cz>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>
CC: linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
        Francesco Ruggeri <fruggeri@aristanetworks.com>,
        Francesco Ruggeri <fruggeri@arista.com>
Subject: Re: [PATCH] Revert "tty: Fix pty master poll() after slave closes
 v2"
References: <1419941829-6536-1-git-send-email-peter@hurleysoftware.com> <54A29B0A.3060707@hurleysoftware.com> <54ABF221.7000305@suse.cz>
In-Reply-To: <54ABF221.7000305@suse.cz>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 01/06/2015 09:33 AM, Jiri Slaby wrote:
> On 12/30/2014, 01:31 PM, Peter Hurley wrote:
>> On 12/30/2014 07:17 AM, Peter Hurley wrote:
>>> This reverts commit c4dc304677e8d566572c4738d95c48be150c6606.
>>> This fix is superseded by commit 52bce7f8d4fc633c9a9d0646eef58ba6ae9a3b73,
>>> 'pty, n_tty: Simplify input processing on final close'.
>>>
>>> The final close now waits for input processing to complete before
>>> destroying the pty, so poll() does not need to special case this
>>> condition.
>>
>> Greg,
>>
>> As noted in this commit log, commit c4dc304677e8d566572c4738d95c48be150c6606,
>> 'tty: Fix pty master poll() after slave closes v2', is not required
>> after commit 52bce7f8d4fc633c9a9d0646eef58ba6ae9a3b73,
>> 'pty, n_tty: Simplify input processing on final close'
>>
>> However, 'tty: Fix pty master poll() after slave closes v2' is appropriate
>> for stable back to v3.12.
> 
> Now applied to 3.12. A backport was needed due to the later change of
> the input_available_p 2nd parameter.

Thanks Jiri.