From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756473AbbAGI6I (ORCPT ); Wed, 7 Jan 2015 03:58:08 -0500 Received: from mail-wg0-f42.google.com ([74.125.82.42]:41617 "EHLO mail-wg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755776AbbAGI6E (ORCPT ); Wed, 7 Jan 2015 03:58:04 -0500 Message-ID: <54ACF516.4080602@dev.mellanox.co.il> Date: Wed, 07 Jan 2015 10:57:58 +0200 From: Sagi Grimberg User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: "Nicholas A. Bellinger" CC: linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [target:nvme_of 3/3] drivers/target/nvme_of/nvme_of_configfs.c:25:31: sparse: symbol 'nvme_of_fabric_configfs' was not declared. Should it be static? References: <201501070334.EgwC5iey%fengguang.wu@intel.com> <1420584282.6927.62.camel@haakon3.risingtidesystems.com> In-Reply-To: <1420584282.6927.62.camel@haakon3.risingtidesystems.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1/7/2015 12:44 AM, Nicholas A. Bellinger wrote: > On Wed, 2015-01-07 at 03:35 +0800, kbuild test robot wrote: >> tree: git://git.kernel.org/pub/scm/linux/kernel/git/nab/target-pending.git nvme_of >> head: 40d8c11927282d59855d645b35798edd97828da5 >> commit: 40d8c11927282d59855d645b35798edd97828da5 [3/3] nvme_of: Initial skeleton commit >> reproduce: >> # apt-get install sparse >> git checkout 40d8c11927282d59855d645b35798edd97828da5 >> make ARCH=x86_64 allmodconfig >> make C=1 CF=-D__CHECK_ENDIAN__ >> >> >> sparse warnings: (new ones prefixed by >>) >> >>>> drivers/target/nvme_of/nvme_of_configfs.c:25:31: sparse: symbol 'nvme_of_fabric_configfs' was not declared. Should it be static? >> >> Please review and possibly fold the followup patch. >> > > Fixed. Thanks Fengguang! > Hey Nic, Hope all is well. So this skeleton is interesting to me. As this is a fabric module I assume this would be the NVMEoFabrics target mode driver for upstream which would be able to talk to NVMEoFabrics initiator (which by the way makes LIO something more than a SCSI target - will this be accepted?). I'm currently participating in nvmexpress working group defining the standard of protocol, specifically in the context of RDMA (naturally). I'm interested in taking an active role in this project, It is important to build this layered from day one - separating the fabric logic (RDMA or FCoE) from the core layer. Moreover, I know that Mellanox has some plans on accelerating this area in future devices and we are currently looking into ways to do that. I want to see that the SW will be able to support that. So, Thoughts? Sagi.