From: Adrian Hunter <adrian.hunter@intel.com>
To: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
Cc: Arnaldo Carvalho de Melo <acme@kernel.org>,
Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@redhat.com>,
Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org>,
Waiman Long <Waiman.Long@hp.com>,
Stephane Eranian <eranian@google.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tools: perf: util: dso: Remove some unused functions
Date: Wed, 07 Jan 2015 11:57:34 +0200 [thread overview]
Message-ID: <54AD030E.5000201@intel.com> (raw)
In-Reply-To: <CAKXHbyP54J4ZaiMVGMvVUXh4ie0zsQhwc9TEbPEqE9x6W_RyxQ@mail.gmail.com>
On 06/01/15 20:05, Rickard Strandqvist wrote:
> 2015-01-05 8:24 GMT+01:00 Adrian Hunter <adrian.hunter@intel.com>:
>> On 02/01/15 23:03, Rickard Strandqvist wrote:
>>> Removes some functions that are not used anywhere:
>>> dso__data_size() dso__data_status_seen()
>>>
>>> This was partially found by using a static code analysis program called cppcheck.
>>>
>>> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
>>> ---
>>
>> Please do not remove these. They are also preparation for Intel PT.
>>
>
>
> Hi
>
> Ok, sorry!
>
> But this obvious, or would it not be good to add same comments?
The Intel PT preparation is a little unusual, and of course I am always
optimistic about getting the rest of the patches added. Adding a comment
only to remove it later seems a bit messy.
prev parent reply other threads:[~2015-01-07 9:59 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-02 21:03 [PATCH] tools: perf: util: dso: Remove some unused functions Rickard Strandqvist
2015-01-05 7:24 ` Adrian Hunter
2015-01-06 18:05 ` Rickard Strandqvist
2015-01-07 9:57 ` Adrian Hunter [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54AD030E.5000201@intel.com \
--to=adrian.hunter@intel.com \
--cc=Waiman.Long@hp.com \
--cc=a.p.zijlstra@chello.nl \
--cc=acme@kernel.org \
--cc=eranian@google.com \
--cc=jolsa@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
--cc=rickard_strandqvist@spectrumdigital.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).