From: Sam Bradshaw <sbradshaw@micron.com>
To: <axboe@kernel.dk>, <linux-kernel@vger.kernel.org>
Cc: <martin.petersen@oracle.com>
Subject: Re: [PATCH] block: pass correct seed to integrity metadata generation function
Date: Wed, 7 Jan 2015 15:08:30 -0800 [thread overview]
Message-ID: <54ADBC6E.50301@micron.com> (raw)
In-Reply-To: <54936D1E.3020700@micron.com>
On 12/18/2014 04:11 PM, Sam Bradshaw wrote:
> The seed value passed to the blk integrity metadata generation function
> was wrong depending on the device block size (interval) and how many
> blocks comprised the bvec. This patch converts the seed to 'interval'
> units and increments it correctly for each iteration. Tested against a
> 4k+8 (w/ type1 PI) sector size.
Any particular objection to this patch? It would be nice if the kernel
supported PI on block sizes other than just 512 bytes.
next prev parent reply other threads:[~2015-01-07 23:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-19 0:11 [PATCH] block: pass correct seed to integrity metadata generation function Sam Bradshaw
2015-01-07 23:08 ` Sam Bradshaw [this message]
2015-01-07 23:25 ` Martin K. Petersen
2015-01-07 23:30 ` Sam Bradshaw (sbradshaw)
2015-01-07 23:42 ` Martin K. Petersen
2015-01-07 23:46 ` Sam Bradshaw (sbradshaw)
2015-01-08 0:19 ` Martin K. Petersen
2015-01-08 0:59 ` Sam Bradshaw (sbradshaw)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54ADBC6E.50301@micron.com \
--to=sbradshaw@micron.com \
--cc=axboe@kernel.dk \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.petersen@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).