* [PATCH] sata: xgene: add ACPI support for APM X-Gene SATA ports @ 2014-12-11 22:31 Feng Kan 2015-01-07 17:32 ` Feng Kan 0 siblings, 1 reply; 7+ messages in thread From: Feng Kan @ 2014-12-11 22:31 UTC (permalink / raw) To: patches, linux-ide, linux-kernel, linux-acpi, msalter, tj, hdegoede Cc: Feng Kan This adds ACPI support for the APM X-Gene SATA ports. When the system boots using ACPI table, the SATA ports are able to configure using the values supplied by the ACPI table rather than the DTS. Signed-off-by: Feng Kan <fkan@apm.com> --- drivers/ata/ahci_xgene.c | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/drivers/ata/ahci_xgene.c b/drivers/ata/ahci_xgene.c index d0c851a..4951392 100644 --- a/drivers/ata/ahci_xgene.c +++ b/drivers/ata/ahci_xgene.c @@ -22,6 +22,7 @@ * NOTE: PM support is not currently available. * */ +#include <linux/acpi.h> #include <linux/module.h> #include <linux/platform_device.h> #include <linux/ahci_platform.h> @@ -521,6 +522,14 @@ disable_resources: return rc; } +#ifdef CONFIG_ACPI +static const struct acpi_device_id xgene_ahci_acpi_match[] = { + { "APMC0D0D", }, + { } +}; +MODULE_DEVICE_TABLE(acpi, xgene_ahci_acpi_match); +#endif + static const struct of_device_id xgene_ahci_of_match[] = { {.compatible = "apm,xgene-ahci"}, {}, @@ -534,6 +543,7 @@ static struct platform_driver xgene_ahci_driver = { .name = "xgene-ahci", .owner = THIS_MODULE, .of_match_table = xgene_ahci_of_match, + .acpi_match_table = ACPI_PTR(xgene_ahci_acpi_match), }, }; -- 1.9.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] sata: xgene: add ACPI support for APM X-Gene SATA ports 2014-12-11 22:31 [PATCH] sata: xgene: add ACPI support for APM X-Gene SATA ports Feng Kan @ 2015-01-07 17:32 ` Feng Kan 2015-01-08 7:50 ` Hanjun Guo 0 siblings, 1 reply; 7+ messages in thread From: Feng Kan @ 2015-01-07 17:32 UTC (permalink / raw) To: patches, linux-ide, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, Mark Salter, tj, hdegoede Cc: Feng Kan Just want to ping this again. Happy new year On Thu, Dec 11, 2014 at 2:31 PM, Feng Kan <fkan@apm.com> wrote: > This adds ACPI support for the APM X-Gene SATA ports. When the system > boots using ACPI table, the SATA ports are able to configure using the > values supplied by the ACPI table rather than the DTS. > > Signed-off-by: Feng Kan <fkan@apm.com> > --- > drivers/ata/ahci_xgene.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/ata/ahci_xgene.c b/drivers/ata/ahci_xgene.c > index d0c851a..4951392 100644 > --- a/drivers/ata/ahci_xgene.c > +++ b/drivers/ata/ahci_xgene.c > @@ -22,6 +22,7 @@ > * NOTE: PM support is not currently available. > * > */ > +#include <linux/acpi.h> > #include <linux/module.h> > #include <linux/platform_device.h> > #include <linux/ahci_platform.h> > @@ -521,6 +522,14 @@ disable_resources: > return rc; > } > > +#ifdef CONFIG_ACPI > +static const struct acpi_device_id xgene_ahci_acpi_match[] = { > + { "APMC0D0D", }, > + { } > +}; > +MODULE_DEVICE_TABLE(acpi, xgene_ahci_acpi_match); > +#endif > + > static const struct of_device_id xgene_ahci_of_match[] = { > {.compatible = "apm,xgene-ahci"}, > {}, > @@ -534,6 +543,7 @@ static struct platform_driver xgene_ahci_driver = { > .name = "xgene-ahci", > .owner = THIS_MODULE, > .of_match_table = xgene_ahci_of_match, > + .acpi_match_table = ACPI_PTR(xgene_ahci_acpi_match), > }, > }; > > -- > 1.9.1 > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] sata: xgene: add ACPI support for APM X-Gene SATA ports 2015-01-07 17:32 ` Feng Kan @ 2015-01-08 7:50 ` Hanjun Guo 2015-01-08 17:56 ` Feng Kan 0 siblings, 1 reply; 7+ messages in thread From: Hanjun Guo @ 2015-01-08 7:50 UTC (permalink / raw) To: Feng Kan, patches, linux-ide, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, Mark Salter, tj, hdegoede Hi Feng Kan, I have some comments below. On 2015年01月08日 01:32, Feng Kan wrote: > Just want to ping this again. > > Happy new year > > On Thu, Dec 11, 2014 at 2:31 PM, Feng Kan <fkan@apm.com> wrote: >> This adds ACPI support for the APM X-Gene SATA ports. When the system >> boots using ACPI table, the SATA ports are able to configure using the >> values supplied by the ACPI table rather than the DTS. >> >> Signed-off-by: Feng Kan <fkan@apm.com> >> --- >> drivers/ata/ahci_xgene.c | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/drivers/ata/ahci_xgene.c b/drivers/ata/ahci_xgene.c >> index d0c851a..4951392 100644 >> --- a/drivers/ata/ahci_xgene.c >> +++ b/drivers/ata/ahci_xgene.c >> @@ -22,6 +22,7 @@ >> * NOTE: PM support is not currently available. >> * >> */ >> +#include <linux/acpi.h> >> #include <linux/module.h> >> #include <linux/platform_device.h> >> #include <linux/ahci_platform.h> >> @@ -521,6 +522,14 @@ disable_resources: >> return rc; >> } >> >> +#ifdef CONFIG_ACPI >> +static const struct acpi_device_id xgene_ahci_acpi_match[] = { >> + { "APMC0D0D", }, When I was going through the PNP and ACPI ID list in http://www.uefi.org/PNP_ACPI_Registry, I found that there is no "APMC" for ACPI ID, I only found that there is a PNP ID "APM" for Applied Memory Tech company, are you using PNP ID for this one? if not, I think you can send a request to UEFI and request a new ACPI ID of "APMC" for Applied Micro, and then submit the patch again. How to send a request to register the ACPI ID, you can refer to: http://www.uefi.org/PNP_ACPI_Registry Thanks Hanjun ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] sata: xgene: add ACPI support for APM X-Gene SATA ports 2015-01-08 7:50 ` Hanjun Guo @ 2015-01-08 17:56 ` Feng Kan 2015-01-08 18:05 ` Hanjun Guo 0 siblings, 1 reply; 7+ messages in thread From: Feng Kan @ 2015-01-08 17:56 UTC (permalink / raw) To: Hanjun Guo Cc: patches, linux-ide, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, Mark Salter, tj, hdegoede On Wed, Jan 7, 2015 at 11:50 PM, Hanjun Guo <hanjun.guo@linaro.org> wrote: > Hi Feng Kan, > > I have some comments below. > > > On 2015年01月08日 01:32, Feng Kan wrote: >> >> Just want to ping this again. >> >> Happy new year >> >> On Thu, Dec 11, 2014 at 2:31 PM, Feng Kan <fkan@apm.com> wrote: >>> >>> This adds ACPI support for the APM X-Gene SATA ports. When the system >>> boots using ACPI table, the SATA ports are able to configure using the >>> values supplied by the ACPI table rather than the DTS. >>> >>> Signed-off-by: Feng Kan <fkan@apm.com> >>> --- >>> drivers/ata/ahci_xgene.c | 10 ++++++++++ >>> 1 file changed, 10 insertions(+) >>> >>> diff --git a/drivers/ata/ahci_xgene.c b/drivers/ata/ahci_xgene.c >>> index d0c851a..4951392 100644 >>> --- a/drivers/ata/ahci_xgene.c >>> +++ b/drivers/ata/ahci_xgene.c >>> @@ -22,6 +22,7 @@ >>> * NOTE: PM support is not currently available. >>> * >>> */ >>> +#include <linux/acpi.h> >>> #include <linux/module.h> >>> #include <linux/platform_device.h> >>> #include <linux/ahci_platform.h> >>> @@ -521,6 +522,14 @@ disable_resources: >>> return rc; >>> } >>> >>> +#ifdef CONFIG_ACPI >>> +static const struct acpi_device_id xgene_ahci_acpi_match[] = { >>> + { "APMC0D0D", }, > > > When I was going through the PNP and ACPI ID list in > http://www.uefi.org/PNP_ACPI_Registry, I found that > there is no "APMC" for ACPI ID, I only found that there is > a PNP ID "APM" for Applied Memory Tech company, are > you using PNP ID for this one? > > if not, I think you can send a request to UEFI and > request a new ACPI ID of "APMC" for Applied Micro, and then > submit the patch again. > > How to send a request to register the ACPI ID, you can > refer to: > http://www.uefi.org/PNP_ACPI_Registry Hanjun, the documents are bit out of sync. We have received approval and it is present in the document link below. I can also forward the approval letter if it needed. http://download.microsoft.com/download/7/E/7/7E7662CF-CBEA-470B-A97E-CE7CE0D98DC2/ISA%20PNPID%20List.xlsx > > Thanks > Hanjun ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] sata: xgene: add ACPI support for APM X-Gene SATA ports 2015-01-08 17:56 ` Feng Kan @ 2015-01-08 18:05 ` Hanjun Guo [not found] ` <CAOHikRA_CVoao-nBcjb=v-j3oR+s6R6cxZBkvrTxNhF_8UD=5Q@mail.gmail.com> 0 siblings, 1 reply; 7+ messages in thread From: Hanjun Guo @ 2015-01-08 18:05 UTC (permalink / raw) To: Feng Kan Cc: patches, linux-ide, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, Mark Salter, tj, hdegoede On 2015年01月09日 01:56, Feng Kan wrote: > On Wed, Jan 7, 2015 at 11:50 PM, Hanjun Guo <hanjun.guo@linaro.org> wrote: >> Hi Feng Kan, >> >> I have some comments below. >> >> >> On 2015年01月08日 01:32, Feng Kan wrote: >>> >>> Just want to ping this again. >>> >>> Happy new year >>> >>> On Thu, Dec 11, 2014 at 2:31 PM, Feng Kan <fkan@apm.com> wrote: >>>> >>>> This adds ACPI support for the APM X-Gene SATA ports. When the system >>>> boots using ACPI table, the SATA ports are able to configure using the >>>> values supplied by the ACPI table rather than the DTS. >>>> >>>> Signed-off-by: Feng Kan <fkan@apm.com> >>>> --- >>>> drivers/ata/ahci_xgene.c | 10 ++++++++++ >>>> 1 file changed, 10 insertions(+) >>>> >>>> diff --git a/drivers/ata/ahci_xgene.c b/drivers/ata/ahci_xgene.c >>>> index d0c851a..4951392 100644 >>>> --- a/drivers/ata/ahci_xgene.c >>>> +++ b/drivers/ata/ahci_xgene.c >>>> @@ -22,6 +22,7 @@ >>>> * NOTE: PM support is not currently available. >>>> * >>>> */ >>>> +#include <linux/acpi.h> >>>> #include <linux/module.h> >>>> #include <linux/platform_device.h> >>>> #include <linux/ahci_platform.h> >>>> @@ -521,6 +522,14 @@ disable_resources: >>>> return rc; >>>> } >>>> >>>> +#ifdef CONFIG_ACPI >>>> +static const struct acpi_device_id xgene_ahci_acpi_match[] = { >>>> + { "APMC0D0D", }, >> >> >> When I was going through the PNP and ACPI ID list in >> http://www.uefi.org/PNP_ACPI_Registry, I found that >> there is no "APMC" for ACPI ID, I only found that there is >> a PNP ID "APM" for Applied Memory Tech company, are >> you using PNP ID for this one? >> >> if not, I think you can send a request to UEFI and >> request a new ACPI ID of "APMC" for Applied Micro, and then >> submit the patch again. >> >> How to send a request to register the ACPI ID, you can >> refer to: >> http://www.uefi.org/PNP_ACPI_Registry > > Hanjun, the documents are bit out of sync. We have received approval and > it is present in the document link below. I can also forward the approval letter > if it needed. > > http://download.microsoft.com/download/7/E/7/7E7662CF-CBEA-470B-A97E-CE7CE0D98DC2/ISA%20PNPID%20List.xlsx Sorry for missing this link, I think I should report this inconsistency to ACPI spec working group and then update it accordingly. Thanks Hanjun ^ permalink raw reply [flat|nested] 7+ messages in thread
[parent not found: <CAOHikRA_CVoao-nBcjb=v-j3oR+s6R6cxZBkvrTxNhF_8UD=5Q@mail.gmail.com>]
* Re: [PATCH] sata: xgene: add ACPI support for APM X-Gene SATA ports [not found] ` <CAOHikRA_CVoao-nBcjb=v-j3oR+s6R6cxZBkvrTxNhF_8UD=5Q@mail.gmail.com> @ 2015-01-13 6:29 ` Hanjun Guo 2015-03-17 18:22 ` Feng Kan 0 siblings, 1 reply; 7+ messages in thread From: Hanjun Guo @ 2015-01-13 6:29 UTC (permalink / raw) To: Suman Tripathi Cc: Feng Kan, patches, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, Mark Salter, Tejun Heo, hdegoede On 2015年01月13日 05:07, Suman Tripathi wrote: > Hi, > > Tested-by: Suman Tripathi <stripathi@apm.com> > > On Thu, Jan 8, 2015 at 11:35 PM, Hanjun Guo <hanjun.guo@linaro.org > <mailto:hanjun.guo@linaro.org>> wrote: > > On 2015年01月09日 01:56, Feng Kan wrote: > > On Wed, Jan 7, 2015 at 11:50 PM, Hanjun Guo > <hanjun.guo@linaro.org <mailto:hanjun.guo@linaro.org>> wrote: > > Hi Feng Kan, > > I have some comments below. > > > On 2015年01月08日 01:32, Feng Kan wrote: > > > Just want to ping this again. > > Happy new year > > On Thu, Dec 11, 2014 at 2:31 PM, Feng Kan <fkan@apm.com > <mailto:fkan@apm.com>> wrote: > > > This adds ACPI support for the APM X-Gene SATA > ports. When the system > boots using ACPI table, the SATA ports are able to > configure using the > values supplied by the ACPI table rather than the DTS. > > Signed-off-by: Feng Kan <fkan@apm.com > <mailto:fkan@apm.com>> > --- > drivers/ata/ahci_xgene.c | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/drivers/ata/ahci_xgene.c > b/drivers/ata/ahci_xgene.c > index d0c851a..4951392 100644 > --- a/drivers/ata/ahci_xgene.c > +++ b/drivers/ata/ahci_xgene.c > @@ -22,6 +22,7 @@ > * NOTE: PM support is not currently available. > * > */ > +#include <linux/acpi.h> > #include <linux/module.h> > #include <linux/platform_device.h> > #include <linux/ahci_platform.h> > @@ -521,6 +522,14 @@ disable_resources: > return rc; > } > > +#ifdef CONFIG_ACPI > +static const struct acpi_device_id > xgene_ahci_acpi_match[] = { > + { "APMC0D0D", }, > > > > When I was going through the PNP and ACPI ID list in > http://www.uefi.org/PNP_ACPI___Registry > <http://www.uefi.org/PNP_ACPI_Registry>, I found that > there is no "APMC" for ACPI ID, I only found that there is > a PNP ID "APM" for Applied Memory Tech company, are > you using PNP ID for this one? > > if not, I think you can send a request to UEFI and > request a new ACPI ID of "APMC" for Applied Micro, and then > submit the patch again. > > How to send a request to register the ACPI ID, you can > refer to: > http://www.uefi.org/PNP_ACPI___Registry > <http://www.uefi.org/PNP_ACPI_Registry> > > > Hanjun, the documents are bit out of sync. We have received > approval and > it is present in the document link below. I can also forward the > approval letter > if it needed. > > http://download.microsoft.com/__download/7/E/7/7E7662CF-CBEA-__470B-A97E-CE7CE0D98DC2/ISA%__20PNPID%20List.xlsx > <http://download.microsoft.com/download/7/E/7/7E7662CF-CBEA-470B-A97E-CE7CE0D98DC2/ISA%20PNPID%20List.xlsx> > > > Sorry for missing this link, I think I should report this > inconsistency to ACPI spec working group and then update it > accordingly. Also I had reported this issue to ASWG and some people will check with this issue and fix it, so Reviewed-by: Hanjun Guo <hanjun.guo@linaro.org> Thanks Hanjun ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] sata: xgene: add ACPI support for APM X-Gene SATA ports 2015-01-13 6:29 ` Hanjun Guo @ 2015-03-17 18:22 ` Feng Kan 0 siblings, 0 replies; 7+ messages in thread From: Feng Kan @ 2015-03-17 18:22 UTC (permalink / raw) To: Hanjun Guo Cc: Suman Tripathi, patches, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, Mark Salter, Tejun Heo, hdegoede On Mon, Jan 12, 2015 at 10:29 PM, Hanjun Guo <hanjun.guo@linaro.org> wrote: > On 2015年01月13日 05:07, Suman Tripathi wrote: >> >> Hi, >> >> Tested-by: Suman Tripathi <stripathi@apm.com> >> >> On Thu, Jan 8, 2015 at 11:35 PM, Hanjun Guo <hanjun.guo@linaro.org >> <mailto:hanjun.guo@linaro.org>> wrote: >> >> On 2015年01月09日 01:56, Feng Kan wrote: >> >> On Wed, Jan 7, 2015 at 11:50 PM, Hanjun Guo >> <hanjun.guo@linaro.org <mailto:hanjun.guo@linaro.org>> wrote: >> >> Hi Feng Kan, >> >> I have some comments below. >> >> >> On 2015年01月08日 01:32, Feng Kan wrote: >> >> >> Just want to ping this again. >> >> Happy new year >> >> On Thu, Dec 11, 2014 at 2:31 PM, Feng Kan <fkan@apm.com >> <mailto:fkan@apm.com>> wrote: >> >> >> This adds ACPI support for the APM X-Gene SATA >> ports. When the system >> boots using ACPI table, the SATA ports are able to >> configure using the >> values supplied by the ACPI table rather than the DTS. >> >> Signed-off-by: Feng Kan <fkan@apm.com >> <mailto:fkan@apm.com>> >> --- >> drivers/ata/ahci_xgene.c | 10 ++++++++++ >> 1 file changed, 10 insertions(+) >> >> diff --git a/drivers/ata/ahci_xgene.c >> b/drivers/ata/ahci_xgene.c >> index d0c851a..4951392 100644 >> --- a/drivers/ata/ahci_xgene.c >> +++ b/drivers/ata/ahci_xgene.c >> @@ -22,6 +22,7 @@ >> * NOTE: PM support is not currently available. >> * >> */ >> +#include <linux/acpi.h> >> #include <linux/module.h> >> #include <linux/platform_device.h> >> #include <linux/ahci_platform.h> >> @@ -521,6 +522,14 @@ disable_resources: >> return rc; >> } >> >> +#ifdef CONFIG_ACPI >> +static const struct acpi_device_id >> xgene_ahci_acpi_match[] = { >> + { "APMC0D0D", }, >> >> >> >> When I was going through the PNP and ACPI ID list in >> http://www.uefi.org/PNP_ACPI___Registry >> <http://www.uefi.org/PNP_ACPI_Registry>, I found that >> there is no "APMC" for ACPI ID, I only found that there is >> a PNP ID "APM" for Applied Memory Tech company, are >> you using PNP ID for this one? >> >> if not, I think you can send a request to UEFI and >> request a new ACPI ID of "APMC" for Applied Micro, and then >> submit the patch again. >> >> How to send a request to register the ACPI ID, you can >> refer to: >> http://www.uefi.org/PNP_ACPI___Registry >> <http://www.uefi.org/PNP_ACPI_Registry> >> >> >> Hanjun, the documents are bit out of sync. We have received >> approval and >> it is present in the document link below. I can also forward the >> approval letter >> if it needed. >> >> >> http://download.microsoft.com/__download/7/E/7/7E7662CF-CBEA-__470B-A97E-CE7CE0D98DC2/ISA%__20PNPID%20List.xlsx >> >> <http://download.microsoft.com/download/7/E/7/7E7662CF-CBEA-470B-A97E-CE7CE0D98DC2/ISA%20PNPID%20List.xlsx> >> >> >> Sorry for missing this link, I think I should report this >> inconsistency to ACPI spec working group and then update it >> accordingly. > > > Also I had reported this issue to ASWG and some people will > check with this issue and fix it, so > > Reviewed-by: Hanjun Guo <hanjun.guo@linaro.org> Hi. Is there a chance this can make it into tree. Thanks > > Thanks > Hanjun ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-03-17 18:22 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-12-11 22:31 [PATCH] sata: xgene: add ACPI support for APM X-Gene SATA ports Feng Kan
2015-01-07 17:32 ` Feng Kan
2015-01-08 7:50 ` Hanjun Guo
2015-01-08 17:56 ` Feng Kan
2015-01-08 18:05 ` Hanjun Guo
[not found] ` <CAOHikRA_CVoao-nBcjb=v-j3oR+s6R6cxZBkvrTxNhF_8UD=5Q@mail.gmail.com>
2015-01-13 6:29 ` Hanjun Guo
2015-03-17 18:22 ` Feng Kan
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).