[GIT PULL] make mrproper fix for v3.19-rc4

[GIT PULL] make mrproper fix for v3.19-rc4

[Michal Marek]

Hi Linus,

make mrproper / distclean stopped removing the generated debian/
directory in v3.16. Please pull the fix.

Thanks,
Michal

The following changes since commit 97bf6af1f928216fd6c5a66e8a57bfa95a659672:

  Linux 3.19-rc1 (2014-12-20 17:08:50 -0800)

are available in the git repository at:

  git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild.git 

for you to fetch changes up to a16c5f99a28c9945165c46da27fff8e6f26f8736:

  kbuild: Fix removal of the debian/ directory (2015-01-02 14:51:27 +0100)

----------------------------------------------------------------
Michal Marek (1):
      kbuild: Fix removal of the debian/ directory

 scripts/Makefile.clean | 16 ++++++++--------
 1 file changed, 8 insertions(+), 8 deletions(-)

Re: [GIT PULL] make mrproper fix for v3.19-rc4

[Michal Marek]

On 2015-01-08 11:49, Michal Marek wrote:
> Hi Linus,
> 
> make mrproper / distclean stopped removing the generated debian/
> directory in v3.16. Please pull the fix.
> 
> Thanks,
> Michal
> 
> The following changes since commit 97bf6af1f928216fd6c5a66e8a57bfa95a659672:
> 
>   Linux 3.19-rc1 (2014-12-20 17:08:50 -0800)
> 
> are available in the git repository at:
> 
>   git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild.git 

Sorry, git-request-pull for some reason does not see the commit in the
remote repository and did not print the branch name here. But it is
there, please pull from

git://git.kernel.org/pub/scm/linux/kernel/git/mmarek/kbuild.git rc-fixes

Thanks,
Michal

Re: [GIT PULL] make mrproper fix for v3.19-rc4

[Linus Torvalds]

On Thu, Jan 8, 2015 at 2:49 AM, Michal Marek <mmarek@suse.cz> wrote:
>
> make mrproper / distclean stopped removing the generated debian/
> directory in v3.16.

So "make distclean" still doesn't actually clean everything.

I don't personally much care, since I've taught my fingers to just do

    git clean -dqfx

instead, but since I tested "make distclean" after pulling from you, I
thought I'd just mention it.

Just do

    make allmodconfig
    .. build the tree ..
    make distclean
    git ls-files -o

to see any files that are left-over despite the distclean ("git
ls-files -o" basically shows all untracked files - 'o' stands for
'others' - so anything that isn't in the actual distributed sources
shows up)

But I really am not sure how much effort we should spend on "make
distclean", given than "git clean" is so much easier and requires no
effort at all.

                      Linus

Re: [GIT PULL] make mrproper fix for v3.19-rc4

[Michal Marek]

On 2015-01-08 23:42, Linus Torvalds wrote:
> Just do
> 
>     make allmodconfig
>     .. build the tree ..
>     make distclean
>     git ls-files -o
> 
> to see any files that are left-over despite the distclean ("git
> ls-files -o" basically shows all untracked files - 'o' stands for
> 'others' - so anything that isn't in the actual distributed sources
> shows up)

The x86 files should actually be removed by make clean. The bug is that
the $(targets) variable must not depend on the configuration, so that
make clean always knows what to delete. I'll send a patch to the x86
maintainers, but such bugs keep creeping in. Other archs possibly have a
similar prolbem.

security/tomoyo automatically generates files that can also be supplied
by the user, which sucks, because make clean does not know whether they
are generated or user supplied.


> But I really am not sure how much effort we should spend on "make
> distclean", given than "git clean" is so much easier and requires no
> effort at all.

With git clean and git archive, there is indeed little use for make
distclean. But clean and mrproper should work.

Michal