From: Paolo Bonzini <pbonzini@redhat.com>
To: Andrej Manduch <amanduch@gmail.com>,
Nicholas Krause <xerofoify@gmail.com>,
gleb@kernel.org
Cc: x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2] arch:x86:kvm:Add function for setting pending timer on virtual cpu in x86.c
Date: Thu, 08 Jan 2015 13:32:09 +0100 [thread overview]
Message-ID: <54AE78C9.9010308@redhat.com> (raw)
In-Reply-To: <54AE74F2.7050700@gmail.com>
On 08/01/2015 13:15, Andrej Manduch wrote:
>>> >> - /* FIXME: this code should not know anything about vcpus */
> I don't want to sounds like I'm nitpicking. But I need to ask. Why is
> this comment removed?
Because the real point of the comment was that the code should not know
anything about VCPU requests. But it's okay to call a function to tell
the VCPU "we want you to call us back at kvm_inject_apic_timer_irqs".
Paolo
>>> >> - kvm_make_request(KVM_REQ_PENDING_TIMER, vcpu);
>>> >> + kvm_set_pending_timer(vcpu);
prev parent reply other threads:[~2015-01-08 12:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1420167918-2190-1-git-send-email-xerofoify@gmail.com>
2015-01-08 11:57 ` [PATCHv2] arch:x86:kvm:Add function for setting pending timer on virtual cpu in x86.c Paolo Bonzini
2015-01-08 12:15 ` Andrej Manduch
2015-01-08 12:32 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54AE78C9.9010308@redhat.com \
--to=pbonzini@redhat.com \
--cc=amanduch@gmail.com \
--cc=gleb@kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
--cc=xerofoify@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox