From: Eric Sandeen <sandeen@sandeen.net>
To: Jaegeuk Kim <jaegeuk@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net
Subject: Re: [PATCH 2/6] f2fs: support goingdown for fs shutdown
Date: Thu, 08 Jan 2015 14:33:17 -0600 [thread overview]
Message-ID: <54AEE98D.5010103@sandeen.net> (raw)
In-Reply-To: <20150108201843.GA74570@jaegeuk-mac02>
On 1/8/15 2:18 PM, Jaegeuk Kim wrote:
> On Thu, Jan 08, 2015 at 01:54:20PM -0600, Eric Sandeen wrote:
>> On 1/8/15 12:10 PM, Jaegeuk Kim wrote:
>>> This patch add an ioctl to shutdown f2fs, which stops all the further block
>>> writes after this point.
>>
>> would it make sense to just re-use the xfs ioctl nr, if the semantics are
>> the same?
>
> The semantics are not same for now.
> In order to reuse xfs ioctl, it needs to support options for flushing logs.
the xfs iotl has 3 behaviors optional:
#define XFS_FSOP_GOING_FLAGS_DEFAULT 0x0 /* going down */
#define XFS_FSOP_GOING_FLAGS_LOGFLUSH 0x1 /* flush log but not data */
#define XFS_FSOP_GOING_FLAGS_NOLOGFLUSH 0x2 /* don't flush log nor data */
if f2fs currently supports a subset, you could just -EOPNOTSUPP on the others.
If the semantics are completely different, maybe it shouldn't share the
name at all. ;)
Just a thought...
-Eric
> Thanks,
>
>>
>> That way any test using it will "just work" on f2fs...
>>
>> -Eric
next prev parent reply other threads:[~2015-01-08 20:33 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-08 18:10 [PATCH 1/6] f2fs: fix wrong unlock_page call Jaegeuk Kim
2015-01-08 18:10 ` [PATCH 2/6] f2fs: support goingdown for fs shutdown Jaegeuk Kim
2015-01-08 19:54 ` Eric Sandeen
2015-01-08 20:18 ` Jaegeuk Kim
2015-01-08 20:33 ` Eric Sandeen [this message]
2015-01-08 20:54 ` Dave Chinner
2015-01-08 21:21 ` Jaegeuk Kim
2015-01-08 22:04 ` Dave Chinner
2015-01-08 22:16 ` Jaegeuk Kim
2015-01-09 1:40 ` [f2fs-dev] [PATCH 2/6 v2] " Jaegeuk Kim
2015-01-09 2:24 ` Dave Chinner
2015-01-09 1:41 ` [PATCH] xfs: use generic FS_IOC_GOINGDOWN for ioctl Jaegeuk Kim
2015-01-09 1:48 ` [PATCH v2] " Jaegeuk Kim
2015-01-09 2:17 ` Dave Chinner
2015-01-08 18:10 ` [PATCH 3/6] f2fs: free radix_tree_nodes used by nat_set entries Jaegeuk Kim
2015-01-08 18:10 ` [PATCH 4/6] f2fs: add nat/sit entries into status Jaegeuk Kim
2015-01-08 18:11 ` [PATCH 5/6] f2fs: add spin_lock to cover radix operations in IO tracer Jaegeuk Kim
2015-01-08 18:11 ` [PATCH 6/6] f2fs: add f2fs_destroy_trace_ios to free radix tree Jaegeuk Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54AEE98D.5010103@sandeen.net \
--to=sandeen@sandeen.net \
--cc=jaegeuk@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox