From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755801AbbAHVXR (ORCPT ); Thu, 8 Jan 2015 16:23:17 -0500 Received: from smtp.codeaurora.org ([198.145.11.231]:35901 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752357AbbAHVXP (ORCPT ); Thu, 8 Jan 2015 16:23:15 -0500 Message-ID: <54AEF541.1090700@codeaurora.org> Date: Thu, 08 Jan 2015 13:23:13 -0800 From: Stephen Boyd User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Krzysztof Kozlowski , Mike Turquette , Sylwester Nawrocki , Tomasz Figa , Kukjin Kim , linux-kernel@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 2/2] clk: exynos-audss: Fix memory leak on driver unbind or probe failure References: <1420451561-12360-1-git-send-email-k.kozlowski@samsung.com> <1420451561-12360-2-git-send-email-k.kozlowski@samsung.com> In-Reply-To: <1420451561-12360-2-git-send-email-k.kozlowski@samsung.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/05/2015 01:52 AM, Krzysztof Kozlowski wrote: > The memory allocated by basic clock divider/gate/mux (struct clk_gate, > clk_divider and clk_mux) was leaking. During driver unbind or probe > failure the driver only unregistered the clocks. > > Use clk_unregister_{gate,divider,mux} to release all resources. > > Signed-off-by: Krzysztof Kozlowski > Reviewed-by: Stephen Boyd -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project