public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Michal Marek <mmarek@suse.cz>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Linux Kbuild mailing list <linux-kbuild@vger.kernel.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] make mrproper fix for v3.19-rc4
Date: Fri, 09 Jan 2015 10:40:25 +0100	[thread overview]
Message-ID: <54AFA209.7030600@suse.cz> (raw)
In-Reply-To: <CA+55aFxrc1CiyjQfWoZHD6UgwOTgj=NVBXPPsY2eygfPMzgsPg@mail.gmail.com>

On 2015-01-08 23:42, Linus Torvalds wrote:
> Just do
> 
>     make allmodconfig
>     .. build the tree ..
>     make distclean
>     git ls-files -o
> 
> to see any files that are left-over despite the distclean ("git
> ls-files -o" basically shows all untracked files - 'o' stands for
> 'others' - so anything that isn't in the actual distributed sources
> shows up)

The x86 files should actually be removed by make clean. The bug is that
the $(targets) variable must not depend on the configuration, so that
make clean always knows what to delete. I'll send a patch to the x86
maintainers, but such bugs keep creeping in. Other archs possibly have a
similar prolbem.

security/tomoyo automatically generates files that can also be supplied
by the user, which sucks, because make clean does not know whether they
are generated or user supplied.


> But I really am not sure how much effort we should spend on "make
> distclean", given than "git clean" is so much easier and requires no
> effort at all.

With git clean and git archive, there is indeed little use for make
distclean. But clean and mrproper should work.

Michal

      reply	other threads:[~2015-01-09  9:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-08 10:49 [GIT PULL] make mrproper fix for v3.19-rc4 Michal Marek
2015-01-08 10:57 ` Michal Marek
2015-01-08 22:42 ` Linus Torvalds
2015-01-09  9:40   ` Michal Marek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54AFA209.7030600@suse.cz \
    --to=mmarek@suse.cz \
    --cc=linux-kbuild@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox