Re: [Xen-devel] [PATCH] x86: xen: mmu: Remove unused function

Jürgen Groß
2015-01-12T08:23:43Z

On 01/11/2015 11:35 PM, Rickard Strandqvist wrote:
> Remove the function set_pte_mfn() that is not used anywhere.
>
> This was partially found by using a static code analysis program called cppcheck.

Sorry, you seem not to have checked the newest kernel.

Used by:

xen_do_set_identity_and_remap_chunk()
xen_remap_memory()

So: Nak.

Juergen

>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@spectrumdigital.se>
> ---
> arch/x86/xen/mmu.c | 9 ---------
> arch/x86/xen/mmu.h | 2 --
> 2 files changed, 11 deletions(-)
>
> diff --git a/arch/x86/xen/mmu.c b/arch/x86/xen/mmu.c
> index a8a1a3d..6959550 100644
> --- a/arch/x86/xen/mmu.c
> +++ b/arch/x86/xen/mmu.c
> @@ -281,15 +281,6 @@ static void xen_set_pmd(pmd_t *ptr, pmd_t val)
> xen_set_pmd_hyper(ptr, val);
> }
>
> -/*
> - * Associate a virtual page frame with a given physical page frame
> - * and protection flags for that frame.
> - */
> -void set_pte_mfn(unsigned long vaddr, unsigned long mfn, pgprot_t flags)
> -{
> - set_pte_vaddr(vaddr, mfn_pte(mfn, flags));
> -}
> -
> static bool xen_batched_set_pte(pte_t *ptep, pte_t pteval)
> {
> struct mmu_update u;
> diff --git a/arch/x86/xen/mmu.h b/arch/x86/xen/mmu.h
> index 73809bb..f2dcf79 100644
> --- a/arch/x86/xen/mmu.h
> +++ b/arch/x86/xen/mmu.h
> @@ -13,8 +13,6 @@ enum pt_level {
>
> bool __set_phys_to_machine(unsigned long pfn, unsigned long mfn);
>
> -void set_pte_mfn(unsigned long vaddr, unsigned long pfn, pgprot_t flags);
> -
> pte_t xen_ptep_modify_prot_start(struct mm_struct *mm, unsigned long addr, pte_t *ptep);
> void xen_ptep_modify_prot_commit(struct mm_struct *mm, unsigned long addr,
> pte_t *ptep, pte_t pte);
>