From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753530AbbALOMQ (ORCPT ); Mon, 12 Jan 2015 09:12:16 -0500 Received: from mail-la0-f42.google.com ([209.85.215.42]:42583 "EHLO mail-la0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752308AbbALOMP (ORCPT ); Mon, 12 Jan 2015 09:12:15 -0500 Message-ID: <54B3D63B.1010608@cogentembedded.com> Date: Mon, 12 Jan 2015 17:12:11 +0300 From: Sergei Shtylyov User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Sanjeev Sharma , davem@davemloft.net CC: claudiu.manoil@freescale.com, peter.senna@gmail.com, shemminger@linux-foundation.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] gianfar: correct the bad expression while writing bit-pattern References: <1421048596-22639-1-git-send-email-sanjeev_sharma@mentor.com> In-Reply-To: <1421048596-22639-1-git-send-email-sanjeev_sharma@mentor.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello. On 1/12/2015 10:43 AM, Sanjeev Sharma wrote: > This patch correct the bad expression while writing the > bit-pattern from software's buffer to hardware registers. > Signed-off-by: Sanjeev Sharma > --- > drivers/net/ethernet/freescale/gianfar_ethtool.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > diff --git a/drivers/net/ethernet/freescale/gianfar_ethtool.c b/drivers/net/ethernet/freescale/gianfar_ethtool.c > index 3e1a9c1..1ccca72 100644 > --- a/drivers/net/ethernet/freescale/gianfar_ethtool.c > +++ b/drivers/net/ethernet/freescale/gianfar_ethtool.c > @@ -1586,7 +1586,7 @@ static int gfar_write_filer_table(struct gfar_private *priv, > return -EBUSY; > > /* Fill regular entries */ > - for (; i < MAX_FILER_IDX - 1 && (tab->fe[i].ctrl | tab->fe[i].ctrl); > + for (; i < MAX_FILER_IDX - 1 && ( i < tab->fe[i].ctrl); Inner parens not needed. And there shouldn't be space after (. WBR, Sergei