From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753103AbbALOWJ (ORCPT ); Mon, 12 Jan 2015 09:22:09 -0500 Received: from mail-wg0-f51.google.com ([74.125.82.51]:59144 "EHLO mail-wg0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751451AbbALOWH (ORCPT ); Mon, 12 Jan 2015 09:22:07 -0500 Message-ID: <54B3D88C.80702@linaro.org> Date: Mon, 12 Jan 2015 15:22:04 +0100 From: Daniel Lezcano User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Nicolas Ferre , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org CC: Boris BREZILLON , Alexandre Belloni , Maxime Ripard , sylvain.rochet@finsecur.com, Thomas Gleixner Subject: Re: [PATCH] clocksource: timer-atmel-pit: don't suspend/resume if unused References: <1418911523-28492-1-git-send-email-nicolas.ferre@atmel.com> <54B3D450.7050405@atmel.com> In-Reply-To: <54B3D450.7050405@atmel.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/12/2015 03:04 PM, Nicolas Ferre wrote: > Le 18/12/2014 15:05, Nicolas Ferre a écrit : >> From: Sylvain Rochet >> >> Waiting for PIT to stop counting takes a long time: >> 1/(Master clock/prescaler/PIVR) >> = 1/(133 MHz /16 /2^20) >> = 126 ms >> >> Up to 126 ms if master clock is set to 133 MHz, skipping suspend/resume >> of the unused PIT device reduce (suspend time + resume time) from ~140 ms >> to ~17 ms. >> >> Signed-off-by: Sylvain Rochet >> [nicolas.ferre@atmel.com: move to newer clocksource driver] >> Signed-off-by: Nicolas Ferre >> Cc: Daniel Lezcano >> --- >> Hi Sylvain, >> >> I re-worked (and "Acked") your patch so it can be applied on the newer Mainline >> kernels. Beware, I changed the "subject line" as well. The PIT driver moved >> recently (3.18). >> >> Daniel, >> Can you take this patch in your tree? > > Hi Daniel, > > Anything prevents this patch from being merged (aka ping ;-))? [Cc'ed tglx]. Hi Nico, thanks for the head up. Nothing prevents it but I am wondering if this change shouldn't be in the generic framework (kernel/time/clocksource.c and kernel/time/clockevents.c), so all drivers will benefit this change ? >> Thanks, bye. >> Nicolas. >> >> drivers/clocksource/timer-atmel-pit.c | 8 ++++++++ >> 1 file changed, 8 insertions(+) >> >> diff --git a/drivers/clocksource/timer-atmel-pit.c b/drivers/clocksource/timer-atmel-pit.c >> index b5b4d4585c9a..5408bc7c68d8 100644 >> --- a/drivers/clocksource/timer-atmel-pit.c >> +++ b/drivers/clocksource/timer-atmel-pit.c >> @@ -123,6 +123,10 @@ static void at91sam926x_pit_suspend(struct clock_event_device *cedev) >> { >> struct pit_data *data = clkevt_to_pit_data(cedev); >> >> + /* Don't suspend PIT if unused */ >> + if (cedev->mode == CLOCK_EVT_MODE_UNUSED) >> + return; >> + >> /* Disable timer */ >> pit_write(data->base, AT91_PIT_MR, 0); >> } >> @@ -145,6 +149,10 @@ static void at91sam926x_pit_resume(struct clock_event_device *cedev) >> { >> struct pit_data *data = clkevt_to_pit_data(cedev); >> >> + /* Don't resume PIT if unused */ >> + if (cedev->mode == CLOCK_EVT_MODE_UNUSED) >> + return; >> + >> at91sam926x_pit_reset(data); >> } >> >> > > -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog