Re: [PATCH v2 1/5] mm/compaction: change tracepoint format from decimal to hexadecimal

Vlastimil Babka
2015-01-12T14:24:03Z

On 01/12/2015 09:21 AM, Joonsoo Kim wrote:
> To check the range that compaction is working, tracepoint print
> start/end pfn of zone and start pfn of both scanner with decimal format.
> Since we manage all pages in order of 2 and it is well represented by
> hexadecimal, this patch change the tracepoint format from decimal to
> hexadecimal. This would improve readability. For example, it makes us
> easily notice whether current scanner try to compact previously
> attempted pageblock or not.
>
> Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>

Acked-by: Vlastimil Babka <vbabka@suse.cz>

> ---
> include/trace/events/compaction.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/trace/events/compaction.h b/include/trace/events/compaction.h
> index c6814b9..1337d9e 100644
> --- a/include/trace/events/compaction.h
> +++ b/include/trace/events/compaction.h
> @@ -104,7 +104,7 @@ TRACE_EVENT(mm_compaction_begin,
> __entry->zone_end = zone_end;
> ),
>
> - TP_printk("zone_start=%lu migrate_start=%lu free_start=%lu zone_end=%lu",
> + TP_printk("zone_start=0x%lx migrate_start=0x%lx free_start=0x%lx zone_end=0x%lx",
> __entry->zone_start,
> __entry->migrate_start,
> __entry->free_start,
>