From: Dave Hansen <dave.hansen@linux.intel.com>
To: Andy Lutomirski <luto@amacapital.net>,
x86@kernel.org, linux-kernel@vger.kernel.org
Cc: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
Subject: Re: [PATCH 3.19 v2 1/3] x86: Fix off-by-one in the instruction decoder length checks
Date: Mon, 12 Jan 2015 15:13:24 -0800 [thread overview]
Message-ID: <54B45514.3070603@linux.intel.com> (raw)
In-Reply-To: <602a94627fedaab4e339088d633b72174caf14c9.1421103159.git.luto@amacapital.net>
On 01/12/2015 03:04 PM, Andy Lutomirski wrote:
> diff --git a/arch/x86/lib/insn.c b/arch/x86/lib/insn.c
> index 2480978b31cc..1313ae6b478b 100644
> --- a/arch/x86/lib/insn.c
> +++ b/arch/x86/lib/insn.c
> @@ -28,7 +28,7 @@
>
> /* Verify next sizeof(t) bytes can be on the same instruction */
> #define validate_next(t, insn, n) \
> - ((insn)->next_byte + sizeof(t) + n < (insn)->end_kaddr)
> + ((insn)->next_byte + sizeof(t) + n <= (insn)->end_kaddr)
>
> #define __get_next(t, insn) \
> ({ t r = *(t*)insn->next_byte; insn->next_byte += sizeof(t); r; })
This issue should already be handled by this patch:
http://git.kernel.org/tip/0f363b250b15af0f218bb2876d101fe5cd413f8b
next prev parent reply other threads:[~2015-01-12 23:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-12 23:04 [PATCH 3.19 v2 0/3] x86, mpx: Instruction decoder fixes and hardening Andy Lutomirski
2015-01-12 23:04 ` [PATCH 3.19 v2 1/3] x86: Fix off-by-one in the instruction decoder length checks Andy Lutomirski
2015-01-12 23:13 ` Dave Hansen [this message]
2015-01-12 23:18 ` Andy Lutomirski
2015-01-12 23:04 ` [PATCH 3.19 v2 2/3] x86, mpx: Short-circuit the instruction decoder for unexpected opcodes Andy Lutomirski
2015-01-12 23:47 ` Dave Hansen
2015-01-12 23:57 ` Andy Lutomirski
2015-01-14 19:43 ` Dave Hansen
2015-01-14 20:24 ` Andy Lutomirski
2015-01-12 23:04 ` [PATCH 3.19 v2 3/3] x86: Enforce MAX_INSN_SIZE in the instruction decoder Andy Lutomirski
2015-01-13 12:20 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B45514.3070603@linux.intel.com \
--to=dave.hansen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=masami.hiramatsu.pt@hitachi.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox