From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753426AbbAMCNF (ORCPT ); Mon, 12 Jan 2015 21:13:05 -0500 Received: from lists.s-osg.org ([54.187.51.154]:47932 "EHLO lists.s-osg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752277AbbAMCND (ORCPT ); Mon, 12 Jan 2015 21:13:03 -0500 Message-ID: <54B47F2D.9020102@osg.samsung.com> Date: Mon, 12 Jan 2015 19:13:01 -0700 From: Shuah Khan Organization: Samsung Open Source Group User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Hans Verkuil , m.chehab@samsung.com, hans.verkuil@cisco.com, dheitmueller@kernellabs.com, prabhakar.csengg@gmail.com, sakari.ailus@linux.intel.com, laurent.pinchart@ideasonboard.com, ttmesterr@gmail.com CC: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 2/3] media: au0828 change to not zero out fmt.pix.priv References: <54b748fa5cb6883d6ce348c38328161409c1f1be.1418918402.git.shuahkh@osg.samsung.com> <54B3D319.2090506@xs4all.nl> In-Reply-To: <54B3D319.2090506@xs4all.nl> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/12/2015 06:58 AM, Hans Verkuil wrote: > My first code review of the new year, so let's start with a simple one to avoid > taxing my brain cells (that are still in vacation mode) too much... > > On 12/18/2014 05:20 PM, Shuah Khan wrote: >> There is no need to zero out fmt.pix.priv in vidioc_g_fmt_vid_cap() >> vidioc_try_fmt_vid_cap(), and vidioc_s_fmt_vid_cap(). Remove it. >> >> Signed-off-by: Shuah Khan > > Acked-by: Hans Verkuil > Thanks. -- Shuah -- Shuah Khan Sr. Linux Kernel Developer Open Source Innovation Group Samsung Research America (Silicon Valley) shuahkh@osg.samsung.com | (970) 217-8978