public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Masami Hiramatsu <masami.hiramatsu.pt@hitachi.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>, vvs@sw.ru
Subject: Re: Bug with jprobes and function graph tracer
Date: Tue, 13 Jan 2015 20:39:33 +0900	[thread overview]
Message-ID: <54B503F5.4020509@hitachi.com> (raw)
In-Reply-To: <20150108122016.0241f713@gandalf.local.home>

(2015/01/09 2:20), Steven Rostedt wrote:
> Hi Masami,
> 
> First, I would like to wish you a Happy New Year :-)

Happy New Year! :)

> OK, now back to business.
> 
> 
> It has come to my attention that jprobes and function graph tracing do
> not play nicely together. I think you once told me they have issues as
> well.
> 
> A simple way to test this is to load the jprobe_example.ko module and
> then run function graph tracing.

I see. Jprobes will mess up the function call path.

> Should we try to fix this? Or should it just be that users need to know
> not to enable the two together. Or we can prevent one from starting if
> the other is being used.

Yeah we should try to fix this, but not so high priority since jprobe
is not used so frequently. I guess one easy solution is adding notrace
to all jprobe handlers for hiding it from function-graph tracer.
If there is a way to check a function is notrace or not, I can use that
in register_jprobe and reject it if the handler is not "notrace"ed. :)

Thank you,

> 
> Looking forward to hearing your thoughts on the subject.
> 
> -- Steve
> 


-- 
Masami HIRAMATSU
Software Platform Research Dept. Linux Technology Research Center
Hitachi, Ltd., Yokohama Research Laboratory
E-mail: masami.hiramatsu.pt@hitachi.com



  reply	other threads:[~2015-01-13 11:39 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-08 17:20 Bug with jprobes and function graph tracer Steven Rostedt
2015-01-13 11:39 ` Masami Hiramatsu [this message]
2015-01-13 12:22   ` Steven Rostedt
2015-01-13 12:46     ` Masami Hiramatsu
2015-01-14 13:49       ` Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54B503F5.4020509@hitachi.com \
    --to=masami.hiramatsu.pt@hitachi.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rostedt@goodmis.org \
    --cc=vvs@sw.ru \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox