From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753229AbbAMP6b (ORCPT ); Tue, 13 Jan 2015 10:58:31 -0500 Received: from eusmtp01.atmel.com ([212.144.249.243]:4855 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751257AbbAMP62 (ORCPT ); Tue, 13 Jan 2015 10:58:28 -0500 Message-ID: <54B540A2.1020805@atmel.com> Date: Tue, 13 Jan 2015 16:58:26 +0100 From: Nicolas Ferre Organization: atmel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Bo Shen , Alexandre Belloni CC: Boris Brezillon , "Jean-Christophe Plagniol-Villard" , , Subject: Re: [PATCH 6/7] ARM: at91: remove useless at91rm9200_dt_initialize() References: <1421088136-10172-1-git-send-email-alexandre.belloni@free-electrons.com> <1421088136-10172-7-git-send-email-alexandre.belloni@free-electrons.com> <54B473D3.6090008@atmel.com> In-Reply-To: <54B473D3.6090008@atmel.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.161.30.18] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 13/01/2015 02:24, Bo Shen a écrit : > Hi Alexandre, > > On 01/13/2015 02:42 AM, Alexandre Belloni wrote: >> at91rm9200_dt_initialize() is doing the same as at91_dit_initialize(), use that > > s/at91_dit_initialize/at91_dt_initialize Alex I'll correct that when including it to the at91-3.20-cleanup branch. No need to resend. Voice: thanks for the review. Bye, >> one instead. >> >> Signed-off-by: Alexandre Belloni >> --- >> arch/arm/mach-at91/board-dt-rm9200.c | 2 +- >> arch/arm/mach-at91/generic.h | 1 - >> arch/arm/mach-at91/setup.c | 7 ------- >> 3 files changed, 1 insertion(+), 9 deletions(-) >> >> diff --git a/arch/arm/mach-at91/board-dt-rm9200.c b/arch/arm/mach-at91/board-dt-rm9200.c >> index 76dfe8f9af50..a15ab6f8de00 100644 >> --- a/arch/arm/mach-at91/board-dt-rm9200.c >> +++ b/arch/arm/mach-at91/board-dt-rm9200.c >> @@ -38,6 +38,6 @@ static const char *at91rm9200_dt_board_compat[] __initdata = { >> DT_MACHINE_START(at91rm9200_dt, "Atmel AT91RM9200 (Device Tree)") >> .init_time = at91rm9200_dt_timer_init, >> .map_io = at91_map_io, >> - .init_early = at91rm9200_dt_initialize, >> + .init_early = at91_dt_initialize, >> .dt_compat = at91rm9200_dt_board_compat, >> MACHINE_END >> diff --git a/arch/arm/mach-at91/generic.h b/arch/arm/mach-at91/generic.h >> index e0368aa06390..c10c2ddaae6d 100644 >> --- a/arch/arm/mach-at91/generic.h >> +++ b/arch/arm/mach-at91/generic.h >> @@ -22,7 +22,6 @@ extern void __init at91_init_sram(int bank, unsigned long base, >> >> /* Processors */ >> extern void __init at91rm9200_set_type(int type); >> -extern void __init at91rm9200_dt_initialize(void); >> extern void __init at91_dt_initialize(void); >> >> /* Timer */ >> diff --git a/arch/arm/mach-at91/setup.c b/arch/arm/mach-at91/setup.c >> index ce25e85720fb..acb8d7724609 100644 >> --- a/arch/arm/mach-at91/setup.c >> +++ b/arch/arm/mach-at91/setup.c >> @@ -429,13 +429,6 @@ static void at91_dt_ramc(void) >> at91_pm_set_standby(standby); >> } >> >> -void __init at91rm9200_dt_initialize(void) >> -{ >> - at91_dt_ramc(); >> - >> - at91_boot_soc.init(); >> -} >> - >> void __init at91_dt_initialize(void) >> { >> at91_dt_ramc(); >> > > Best Regards, > Bo Shen > -- Nicolas Ferre