From: Mark Salyzyn <salyzyn@android.com>
To: Kees Cook <keescook@chromium.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Anton Vorontsov <anton@enomsg.org>,
Colin Cross <ccross@android.com>, Tony Luck <tony.luck@intel.com>
Subject: Re: [PATCH 3/5] pstore: handle zero-sized prz in series
Date: Tue, 13 Jan 2015 15:42:41 -0800 [thread overview]
Message-ID: <54B5AD71.80404@android.com> (raw)
In-Reply-To: <CAGXu5jKeTzBepFogZvi0JbXnU8MuEi2tcQ45pQLdFMymmugvgw@mail.gmail.com>
On 01/13/2015 03:08 PM, Kees Cook wrote:
> On Tue, Jan 13, 2015 at 2:32 PM, Mark Salyzyn <salyzyn@android.com> wrote:
>> ramoops_pstore_read fails to return the next in a prz
>> series after first zero-sized entry, not venturing to
>> the next non-zero entry.
>>
>> Signed-off-by: Mark Salyzyn <salyzyn@android.com>
> This seems fine. Out of curiosity, when was the bad behavior this encountered?
During integration testing of the pmsg interface, we found that if any
(most notably ftrace) of the previous prz's were zero in length. Before
the addition of pmsg it would have occurred if you zero'd the console
size, but had ftrace set; an unlikely scenario _until_ pmsg was added.
>
> Acked-by: Kees Cook <keescook@chromium.org>
>
> Thanks!
>
> -Kees
>
Thanks
prev parent reply other threads:[~2015-01-13 23:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-13 22:32 [PATCH 3/5] pstore: handle zero-sized prz in series Mark Salyzyn
2015-01-13 23:08 ` Kees Cook
2015-01-13 23:42 ` Mark Salyzyn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B5AD71.80404@android.com \
--to=salyzyn@android.com \
--cc=anton@enomsg.org \
--cc=ccross@android.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox