From: hejianet <jiakernel@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: Oleg Drokin <oleg.drokin@intel.com>,
Andreas Dilger <andreas.dilger@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH] staging: lustre: libcfs: fix sparse warnings about static declaration
Date: Wed, 14 Jan 2015 11:49:34 +0800 [thread overview]
Message-ID: <54B5E74E.3080101@gmail.com> (raw)
In-Reply-To: <1418740778-827-1-git-send-email-hejianet@gmail.com>
Hi all
Ping again, any comments are welcome
Justin
On Tue, 16 Dec 2014 22:39:38 +0800 from hejianet@gmail.com wrote:
> make sparse happy since these two fuchtion are only used in module.c.
> tested by successful compilation.
>
> Signed-off-by: Jia He <hejianet@gmail.com>
> Cc: Oleg Drokin <oleg.drokin@intel.com>
> Cc: Andreas Dilger <andreas.dilger@intel.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> ---
> drivers/staging/lustre/lustre/libcfs/module.c | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/staging/lustre/lustre/libcfs/module.c b/drivers/staging/lustre/lustre/libcfs/module.c
> index 2c4fc74..b9ee37c 100644
> --- a/drivers/staging/lustre/lustre/libcfs/module.c
> +++ b/drivers/staging/lustre/lustre/libcfs/module.c
> @@ -42,8 +42,7 @@
> #include "../../include/linux/lnet/lnet.h"
> #include "tracefile.h"
>
> -void
> -kportal_memhog_free (struct libcfs_device_userstate *ldu)
> +static void kportal_memhog_free (struct libcfs_device_userstate *ldu)
> {
> struct page **level0p = &ldu->ldu_memhog_root_page;
> struct page **level1p;
> @@ -86,8 +85,7 @@ kportal_memhog_free (struct libcfs_device_userstate *ldu)
> LASSERT (ldu->ldu_memhog_pages == 0);
> }
>
> -int
> -kportal_memhog_alloc(struct libcfs_device_userstate *ldu, int npages,
> +static int kportal_memhog_alloc(struct libcfs_device_userstate *ldu, int npages,
> gfp_t flags)
> {
> struct page **level0p;
next prev parent reply other threads:[~2015-01-14 3:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-16 14:39 [PATCH] staging: lustre: libcfs: fix sparse warnings about static declaration Jia He
2014-12-29 2:42 ` hejianet
2015-01-14 3:49 ` hejianet [this message]
2015-01-14 6:35 ` Jeremiah Mahler
2015-01-16 1:45 ` [PATCH 1/2] " Jia He
2015-01-16 1:45 ` [PATCH 2/2] staging: lustre: libcfs: fix space between function and open parenthesis Jia He
2015-01-16 6:21 ` Jeremiah Mahler
2015-01-16 8:58 ` [PATCH] staging: lustre: libcfs: fix sparse warnings about static declaration Jia He
2015-01-16 19:07 ` Jeremiah Mahler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B5E74E.3080101@gmail.com \
--to=jiakernel@gmail.com \
--cc=andreas.dilger@intel.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox