From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753032AbbANNsc (ORCPT ); Wed, 14 Jan 2015 08:48:32 -0500 Received: from eusmtp01.atmel.com ([212.144.249.243]:31277 "EHLO eusmtp01.atmel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751598AbbANNsa (ORCPT ); Wed, 14 Jan 2015 08:48:30 -0500 Message-ID: <54B673AB.6040404@atmel.com> Date: Wed, 14 Jan 2015 14:48:27 +0100 From: Nicolas Ferre Organization: atmel User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Boris Brezillon , Thomas Gleixner , Jason Cooper , "Jean-Christophe Plagniol-Villard" , Alexandre Belloni CC: "Rafael J. Wysocki" , , , "Rob Herring" , Pawel Moll , Mark Rutland , Ian Campbell , "Kumar Gala" , Subject: Re: [PATCH v2 5/5] ARM: at91/dt: define a dumb irq demultiplexer chip connected on irq1 References: <1421174781-4340-1-git-send-email-boris.brezillon@free-electrons.com> <1421174781-4340-6-git-send-email-boris.brezillon@free-electrons.com> In-Reply-To: <1421174781-4340-6-git-send-email-boris.brezillon@free-electrons.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 8bit X-Originating-IP: [10.161.30.18] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 13/01/2015 19:46, Boris Brezillon a écrit : > IRQ is multiplexing several peripheral IRQs, but there's no way to > properly demultiplex those IRQs. > Use a dumb irq demux chip to achieve this demultiplexing operation. > > Signed-off-by: Boris Brezillon > --- > arch/arm/boot/dts/at91sam9260.dtsi | 26 ++++++++++++++++++++------ > 1 file changed, 20 insertions(+), 6 deletions(-) > > diff --git a/arch/arm/boot/dts/at91sam9260.dtsi b/arch/arm/boot/dts/at91sam9260.dtsi > index dd1313c..debe8d2 100644 > --- a/arch/arm/boot/dts/at91sam9260.dtsi > +++ b/arch/arm/boot/dts/at91sam9260.dtsi > @@ -10,7 +10,7 @@ > > #include "skeleton.dtsi" > #include > -#include > +#include > #include > #include > > @@ -89,6 +89,7 @@ > atmel,external-irqs = <29 30 31>; > }; > > + > ramc0: ramc@ffffea00 { > compatible = "atmel,at91sam9260-sdramc"; > reg = <0xffffea00 0x200>; > @@ -97,7 +98,7 @@ > pmc: pmc@fffffc00 { > compatible = "atmel,at91sam9260-pmc"; > reg = <0xfffffc00 0x100>; > - interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>; > + interrupts-extended = <&dumb_irq1_demux AIC_IRQ1_PMC>; > interrupt-controller; > #address-cells = <1>; > #size-cells = <0>; > @@ -364,7 +365,7 @@ > pit: timer@fffffd30 { > compatible = "atmel,at91sam9260-pit"; > reg = <0xfffffd30 0xf>; > - interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>; > + interrupts-extended = <&dumb_irq1_demux AIC_IRQ1_PIT>; > clocks = <&mck>; > }; > > @@ -750,7 +751,7 @@ > dbgu: serial@fffff200 { > compatible = "atmel,at91sam9260-usart"; > reg = <0xfffff200 0x200>; > - interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>; > + interrupts-extended = <&dumb_irq1_demux AIC_IRQ1_DBGU>; > pinctrl-names = "default"; > pinctrl-0 = <&pinctrl_dbgu>; > clocks = <&mck>; > @@ -959,7 +960,7 @@ > rtc@fffffd20 { > compatible = "atmel,at91sam9260-rtt"; > reg = <0xfffffd20 0x10>; > - interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>; > + interrupts-extended = <&dumb_irq1_demux AIC_IRQ1_RTT>; > clocks = <&clk32k>; > status = "disabled"; > }; > @@ -967,7 +968,7 @@ > watchdog@fffffd40 { > compatible = "atmel,at91sam9260-wdt"; > reg = <0xfffffd40 0x10>; > - interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>; > + interrupts-extended = <&dumb_irq1_demux AIC_IRQ1_WATCHDOG>; > atmel,watchdog-type = "hardware"; > atmel,reset-type = "all"; > atmel,dbg-halt; > @@ -1010,6 +1011,19 @@ > }; > }; > > + dumb_irq1_demux: dumb-irq-demux@1 { > + compatible = "irqchip-dumb-demux"; > + interrupt-controller; > + #interrupt-cells = <1>; > + interrupts = <1 IRQ_TYPE_LEVEL_HIGH 7>; > + irqs = <(AIC_IRQ_MASK(AIC_IRQ1_PMC) | > + AIC_IRQ_MASK(AIC_IRQ1_PIT) | > + AIC_IRQ_MASK(AIC_IRQ1_DBGU) | > + AIC_IRQ_MASK(AIC_IRQ1_RTT) | > + AIC_IRQ_MASK(AIC_IRQ1_WATCHDOG) | > + AIC_IRQ_MASK(AIC_IRQ1_RSTC))>; > + }; > + Yep, with the modification that you suggested in "Re: [PATCH v2 4/5] ARM: at91/dt: add AIC irq1 muxed peripheral id definitions" it would be even simpler. Acked-by: Nicolas Ferre > i2c@0 { > compatible = "i2c-gpio"; > gpios = <&pioA 23 GPIO_ACTIVE_HIGH /* sda */ > -- Nicolas Ferre