Re: [PATCH v3 4/4] pinctrl: qcom: Add support for reset for apq8064

Timur Tabi
2015-01-14T23:38:26Z

On Fri, Aug 29, 2014 at 9:30 AM, Pramod Gurav
<pramod.gurav@smartplayin.com> wrote:
>
> +static void msm_pinctrl_setup_pm_reset(struct msm_pinctrl *pctrl)
> +{
> + int i = 0;
> + const struct msm_function *func = pctrl->soc->functions;
> +
> + for (; i <= pctrl->soc->nfunctions; i++)

Shouldn't this be

i < pctrl->soc->nfunctions

As it stands, if nfunctions == 0, this function crashes.

--
Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project.