From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753371AbbAOMLN (ORCPT ); Thu, 15 Jan 2015 07:11:13 -0500 Received: from mail7.hitachi.co.jp ([133.145.228.42]:49904 "EHLO mail7.hitachi.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752828AbbAOMLM (ORCPT ); Thu, 15 Jan 2015 07:11:12 -0500 Message-ID: <54B7AE59.1090400@hitachi.com> Date: Thu, 15 Jan 2015 21:11:05 +0900 From: Masami Hiramatsu Organization: Hitachi, Ltd., Japan User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:13.0) Gecko/20120614 Thunderbird/13.0.1 MIME-Version: 1.0 To: Namhyung Kim Cc: Arnaldo Carvalho de Melo , Ingo Molnar , Peter Zijlstra , Jiri Olsa , LKML , David Ahern Subject: Re: [PATCH v2 4/4] perf probe: Fix probing kretprobes References: <1421234288-22758-1-git-send-email-namhyung@kernel.org> <1421234288-22758-4-git-send-email-namhyung@kernel.org> In-Reply-To: <1421234288-22758-4-git-send-email-namhyung@kernel.org> Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org (2015/01/14 20:18), Namhyung Kim wrote: > The commit dfef99cd0b2c ("perf probe: Use ref_reloc_sym based address > instead of the symbol name") converts kprobes to use ref_reloc_sym > (i.e. _stext) and offset instead of using symbol's name directly. So > on my system, adding do_fork ends up with like below: > > $ sudo perf probe -v --add do_fork%return > probe-definition(0): do_fork%return > symbol:do_fork file:(null) line:0 offset:0 return:1 lazy:(null) > 0 arguments > Looking at the vmlinux_path (7 entries long) > Using /lib/modules/3.17.6-1-ARCH/build/vmlinux for symbols > Could not open debuginfo. Try to use symbols. > Opening /sys/kernel/debug/tracing/kprobe_events write=1 > Added new event: > Writing event: r:probe/do_fork _stext+456136 > Failed to write event: Invalid argument > Error: Failed to add events. Reason: Operation not permitted (Code: -1) > > As you can see, the do_fork was translated to _stext+456136. This was > because to support (local) symbols that have same name. But the > problem is that kretprobe requires to be inserted at function start > point so it simply checks whether it's called with offset 0. And if > not, it'll return with -EINVAL. You can see it with dmesg. > > $ dmesg | tail -1 > [125621.764103] Return probe must be used without offset. > > So we need to use the symbol name instead of ref_reloc_sym in case of > return probes. > > Reported-by: Jiri Olsa > Cc: Masami Hiramatsu Looks good to me! Acked-by: Masami Hiramatsu Thank you, > Signed-off-by: Namhyung Kim > --- > tools/perf/util/probe-event.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c > index b1406d79b271..7c94acc014e9 100644 > --- a/tools/perf/util/probe-event.c > +++ b/tools/perf/util/probe-event.c > @@ -446,7 +446,7 @@ static int post_process_probe_trace_events(struct probe_trace_event *tevs, > } > > for (i = 0; i < ntevs; i++) { > - if (tevs[i].point.address) { > + if (tevs[i].point.address && !tevs[i].point.retprobe) { > tmp = strdup(reloc_sym->name); > if (!tmp) > return -ENOMEM; > @@ -2255,7 +2255,7 @@ static int find_probe_trace_events_from_map(struct perf_probe_event *pev, > goto out; > } > > - if (!pev->uprobes) { > + if (!pev->uprobes && !pp->retprobe) { > kmap = map__kmap(map); > reloc_sym = kmap->ref_reloc_sym; > if (!reloc_sym) { > -- Masami HIRAMATSU Software Platform Research Dept. Linux Technology Research Center Hitachi, Ltd., Yokohama Research Laboratory E-mail: masami.hiramatsu.pt@hitachi.com