From: Jiang Liu <jiang.liu@linux.intel.com>
To: Sander Eikelenboom <linux@eikelenboom.it>
Cc: David Vrabel <david.vrabel@citrix.com>,
Thomas Gleixner <tglx@linutronix.de>,
Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>,
Bjorn Helgaas <bhelgaas@google.com>,
"Rafael J . Wysocki" <rafael.j.wysocki@intel.com>,
Tony Luck <tony.luck@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [Bugfix v4 0/2] Fix xen IRQ allocation failure caused by commit b81975eade8c
Date: Thu, 15 Jan 2015 22:37:02 +0800 [thread overview]
Message-ID: <54B7D08E.7060904@linux.intel.com> (raw)
In-Reply-To: <1681737545.20150115152237@eikelenboom.it>
On 2015/1/15 22:22, Sander Eikelenboom wrote:
>
> Thursday, January 15, 2015, 2:04:34 PM, you wrote:
>
>> With more knowledge of Xen interrupt manangement subsytem, I realized
>> previous three versions to fix https://lkml.org/lkml/2014/12/19/178 are
>> just plainly wrong. Those patches try to fix the issue by creating
>> irqdomain for IOAPICs for PV domains, which effectively let native
>> IOAPIC driver and Xen PV interrupt management subsystem to manage
>> IOAPIC irqs concurrently, sounds unpredictable.
>
>> Sorry for those wrong fixes. The good news is that the new fix does
>> make code simpler and easier to maintain.
>
>> I have tested the patchset on Intel platform with bare metal and Dom0
>> kernels.
>
>> Hi Sander,
>> Could you please help to test it again?
>
>> Regards!
>> Gerry
>
> Hi Gerry,
>
> These patches fix the first symptom of the powerbutton not working.
>
> Unfortunately it doesn't fix the second symptoms with pci-passthrough,
> the device still doesn't receive irq's on intel and the video device still haas
> issues on AMD.
>
> What i have tested extensively and works stable for me is:
> david's patch + revert of cffe0a2b5a34c95a4dadc9ec7132690a5b0f6687 "x86, irq: Keep balance of IOAPIC pin reference count"
>
> Hope that helps in finding the solution.
Hi Sander,
Yes, this is only a fix for power button(ACPI SCI allocation).
I'm still reading xen-pciback code to figure out the possible cause
and fix for the second issue.
Thanks!
Gerry.
>
> --
> Sander
>
>
>> Jiang Liu (2):
>> xen/pci: Kill function xen_setup_acpi_sci()
>> xen/pci: Simplify x86/pci/xen.c by killing gsi_override related code
>
>> arch/x86/kernel/acpi/boot.c | 26 ++++++++---------
>> arch/x86/pci/xen.c | 68 ++++---------------------------------------
>> 2 files changed, 19 insertions(+), 75 deletions(-)
>
>
next prev parent reply other threads:[~2015-01-15 14:37 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-07 6:13 [Bugfix] x86/apic: Fix xen IRQ allocation failure caused by commit b81975eade8c Jiang Liu
2015-01-07 14:50 ` Konrad Rzeszutek Wilk
2015-01-07 15:37 ` Jiang Liu
2015-01-07 15:44 ` Konrad Rzeszutek Wilk
2015-01-08 6:36 ` Jiang Liu
2015-01-09 21:15 ` Konrad Rzeszutek Wilk
2015-01-10 19:12 ` Sander Eikelenboom
2015-01-12 13:39 ` [PATCH v2] " Jiang Liu
2015-01-12 15:01 ` [Xen-devel] " David Vrabel
2015-01-12 23:18 ` Sander Eikelenboom
2015-01-13 9:01 ` Thomas Gleixner
2015-01-14 3:09 ` [PATCH v3] " Jiang Liu
2015-01-14 12:23 ` Sander Eikelenboom
2015-01-14 12:29 ` Jiang Liu
2015-01-15 13:04 ` [Bugfix v4 0/2] " Jiang Liu
2015-01-15 13:04 ` [Bugfix v4 1/2] xen/pci: " Jiang Liu
2015-01-16 18:13 ` Konrad Rzeszutek Wilk
2015-01-19 4:39 ` Jiang Liu
2015-01-19 4:41 ` Jiang Liu
2015-01-20 19:12 ` Konrad Rzeszutek Wilk
2015-01-15 13:04 ` [Bugfix v4 2/2] xen/pci: Simplify x86/pci/xen.c by killing gsi_override related code Jiang Liu
2015-01-15 13:11 ` [Bugfix v4 0/2] Fix xen IRQ allocation failure caused by commit b81975eade8c Sander Eikelenboom
2015-01-15 14:22 ` Sander Eikelenboom
2015-01-15 14:37 ` Jiang Liu [this message]
2015-01-13 2:23 ` [Xen-devel] [PATCH v2] [Bugfix] x86/apic: " Jiang Liu
2015-01-13 10:09 ` David Vrabel
2015-01-13 12:39 ` Jiang Liu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B7D08E.7060904@linux.intel.com \
--to=jiang.liu@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=david.vrabel@citrix.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@eikelenboom.it \
--cc=rafael.j.wysocki@intel.com \
--cc=tglx@linutronix.de \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).