From: Nicolas Dufresne <nicolas.dufresne@collabora.com>
To: "Frédéric Sureau" <frederic.sureau@vodalys.com>,
"Philipp Zabel" <p.zabel@pengutronix.de>,
"Kamil Debski" <k.debski@samsung.com>
Cc: Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
Jean-Michel Hautbois <jean-michel.hautbois@vodalys.com>
Subject: Re: [RFC PATCH] [media] coda: Use S_PARM to set nominal framerate for h.264 encoder
Date: Thu, 15 Jan 2015 11:51:20 -0500 [thread overview]
Message-ID: <54B7F008.9060100@collabora.com> (raw)
In-Reply-To: <54B7E978.5050505@vodalys.com>
Le 2015-01-15 11:23, Frédéric Sureau a écrit :
> Maybe a->parm.output.capability should be set to
> |V4L2_CAP_TIMEPERFRAME| here.
> I think it is required by GStreamer V4L2 plugin.
Looking at this, I think output device is indeed the right place to set
this, and the capability should indeed be updated. Now for the GStreamer
side, it will need patching. At the moment, this cap is only checked for
capture device. It's not a major change to enabled that for output
device with that capability.
cheers,
Nicolas
next prev parent reply other threads:[~2015-01-15 16:51 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-12-22 16:00 [RFC PATCH] [media] coda: Use S_PARM to set nominal framerate for h.264 encoder Philipp Zabel
2015-01-12 15:03 ` Hans Verkuil
2015-01-12 15:35 ` Philipp Zabel
2015-01-12 15:38 ` Hans Verkuil
[not found] ` <54B7E978.5050505@vodalys.com>
2015-01-15 16:51 ` Nicolas Dufresne [this message]
2015-01-15 16:59 ` Frédéric Sureau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B7F008.9060100@collabora.com \
--to=nicolas.dufresne@collabora.com \
--cc=frederic.sureau@vodalys.com \
--cc=jean-michel.hautbois@vodalys.com \
--cc=k.debski@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@osg.samsung.com \
--cc=p.zabel@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox