From: David Daney <ddaney.cavm@gmail.com>
To: Aaro Koskinen <aaro.koskinen@iki.fi>
Cc: Ralf Baechle <ralf@linux-mips.org>,
David Daney <david.daney@cavium.com>,
linux-mips@linux-mips.org, linux-kernel@vger.kernel.org,
Hemmo Nieminen <hemmo.nieminen@iki.fi>,
stable@vger.kernel.org
Subject: Re: [PATCH 1/2] MIPS: OCTEON: fix kernel crash when offlining a CPU
Date: Thu, 15 Jan 2015 12:10:08 -0800 [thread overview]
Message-ID: <54B81EA0.8060409@gmail.com> (raw)
In-Reply-To: <20150115195345.GA8087@fuloong-minipc.musicnaut.iki.fi>
On 01/15/2015 11:53 AM, Aaro Koskinen wrote:
> Hi,
>
> On Thu, Jan 15, 2015 at 11:36:12AM -0800, David Daney wrote:
>> On 01/15/2015 10:49 AM, Aaro Koskinen wrote:
>>> octeon_cpu_disable() will unconditionally enable interrupts when called
>>> with interrupts disabled. Fix that.
>>
>> interrupts are always disabled here, so...
>
> Is that also true for all the currently supported stable kernels...?
I haven't done extensive research recently, but I have removed that pair
of local_irq_disable/local_irq_enable in our SDK kernel based on 3.10
> Or should I just drop Cc: stable from this patch?
>
>> Just remove this...
>>
>>> octeon_fixup_irqs();
>>> - local_irq_enable();
>>> + local_irq_restore(flags);
>>
>> ... and this.
>>
>>>
>>> flush_cache_all();
>>> local_flush_tlb_all();
>>>
>>
>> You can add an Acked-by me if you do that.
>
> Ok, I will do that.
>
> A.
>
>
next prev parent reply other threads:[~2015-01-15 20:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-15 18:49 [PATCH 1/2] MIPS: OCTEON: fix kernel crash when offlining a CPU Aaro Koskinen
2015-01-15 18:49 ` [PATCH 2/2] MIPS: fix kernel lockup or crash after CPU offline/online Aaro Koskinen
2015-01-15 19:36 ` [PATCH 1/2] MIPS: OCTEON: fix kernel crash when offlining a CPU David Daney
2015-01-15 19:53 ` Aaro Koskinen
2015-01-15 20:10 ` David Daney [this message]
2015-01-15 20:24 ` Aaro Koskinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B81EA0.8060409@gmail.com \
--to=ddaney.cavm@gmail.com \
--cc=aaro.koskinen@iki.fi \
--cc=david.daney@cavium.com \
--cc=hemmo.nieminen@iki.fi \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox