From: Bart Van Assche <bart.vanassche@sandisk.com>
To: Nicholas Mc Guire <der.herr@hofr.at>, Roland Dreier <roland@kernel.org>
Cc: Sean Hefty <sean.hefty@intel.com>,
Hal Rosenstock <hal.rosenstock@gmail.com>,
Nicholas Bellinger <nab@linux-iscsi.org>,
"Jingoo Han" <jg1.han@samsung.com>,
Andrew Morton <akpm@linux-foundation.org>,
"Rasmus Villemoes" <linux@rasmusvillemoes.dk>,
Mike Marciniszyn <mike.marciniszyn@intel.com>,
Ira Weiny <ira.weiny@intel.com>,
"Christoph Hellwig" <hch@infradead.org>,
<linux-rdma@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] ib_srpt: wait_for_completion_timeout does not return negativ status
Date: Fri, 16 Jan 2015 12:57:34 +0100 [thread overview]
Message-ID: <54B8FCAE.2020408@sandisk.com> (raw)
In-Reply-To: <1421407217-9105-1-git-send-email-der.herr@hofr.at>
On 01/16/15 12:20, Nicholas Mc Guire wrote:
> Signed-off-by: Nicholas Mc Guire <der.herr@hofr.at>
> ---
>
> Patch is against 3.19.0-rc3 -next-20150109
>
> Patch was compiletested only with x86_64_defconfig +
> CONFIG_TARGET_CORE=m, CONFIG_INFINIBAND=m, CONFIG_INFINIBAND_SRPT=m
>
> drivers/infiniband/ulp/srpt/ib_srpt.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/infiniband/ulp/srpt/ib_srpt.c b/drivers/infiniband/ulp/srpt/ib_srpt.c
> index eb694dd..4e58c76 100644
> --- a/drivers/infiniband/ulp/srpt/ib_srpt.c
> +++ b/drivers/infiniband/ulp/srpt/ib_srpt.c
> @@ -3533,7 +3533,7 @@ static void srpt_close_session(struct se_session *se_sess)
> spin_unlock_irq(&sdev->spinlock);
>
> res = wait_for_completion_timeout(&release_done, 60 * HZ);
> - WARN_ON(res <= 0);
> + WARN_ON(res == 0);
> }
>
> /**
The description of this patch explains why you would like to change this
code but not why this change is useful. Does building the current code
e.g. trigger a compiler warning ? If so, which warning ? If not, why
would you like to change this code and why do you think this change is
an improvement ?
Bart.
next prev parent reply other threads:[~2015-01-16 12:13 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-16 11:20 [PATCH] ib_srpt: wait_for_completion_timeout does not return negativ status Nicholas Mc Guire
2015-01-16 11:57 ` Bart Van Assche [this message]
2015-01-16 12:02 ` Nicholas Mc Guire
2015-01-20 23:51 ` Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54B8FCAE.2020408@sandisk.com \
--to=bart.vanassche@sandisk.com \
--cc=akpm@linux-foundation.org \
--cc=der.herr@hofr.at \
--cc=hal.rosenstock@gmail.com \
--cc=hch@infradead.org \
--cc=ira.weiny@intel.com \
--cc=jg1.han@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=linux@rasmusvillemoes.dk \
--cc=mike.marciniszyn@intel.com \
--cc=nab@linux-iscsi.org \
--cc=roland@kernel.org \
--cc=sean.hefty@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox