From: "Giedrius Statkevičius" <giedrius.statkevicius@gmail.com>
To: Ahmadposten <ahmad.hassan612@gmail.com>, devel@driverdev.osuosl.org
Cc: gclement@baobob.org, tvboxspy@gmail.com,
gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org,
forest@alittletooquiet.net, joe@perches.com
Subject: Re: [PATCH] staging: vt6655: fix space prohibted before that ',' Signed-off-by: Ahmadposten <ahmad.hassan612@gmail.com>
Date: Sun, 18 Jan 2015 17:23:14 +0200 [thread overview]
Message-ID: <54BBCFE2.9030801@gmail.com> (raw)
In-Reply-To: <20150118233831.GA22696@Arch-Thinkpad>
On 2015.01.19 01:38, Ahmadposten wrote:
> ---
> drivers/staging/vt6655/device_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
> index f5cc78e..34e3a76 100644
> --- a/drivers/staging/vt6655/device_main.c
> +++ b/drivers/staging/vt6655/device_main.c
> @@ -1090,7 +1090,7 @@ static irqreturn_t device_intr(int irq, void *dev_instance)
> // Must do this after doing rx/tx, cause ISR bit is slow
> // than RD/TD write back
> // update ISR counter
> - STAvUpdate802_11Counter(&pDevice->s802_11Counter, &pDevice->scStatistic , dwMIBCounter);
> + STAvUpdate802_11Counter(&pDevice->s802_11Counter, &pDevice->scStatistic, dwMIBCounter);
> while (pDevice->dwIsr != 0) {
> STAvUpdateIsrStatCounter(&pDevice->scStatistic, pDevice->dwIsr);
> MACvWriteISR(pDevice->PortOffset, pDevice->dwIsr);
>
Your subject is messed up. The Signed-off-by part should be in the
message before "---". Also, consider adding some text that describes
more precisely what you've changed. By the way, as a newbie you can
always send your patches to yourself before sending it off to a ML to
see if everything is okay.
--
Thanks,
Giedrius
prev parent reply other threads:[~2015-01-18 15:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-18 23:38 [PATCH] staging: vt6655: fix space prohibted before that ',' Signed-off-by: Ahmadposten <ahmad.hassan612@gmail.com> Ahmadposten
2015-01-18 15:23 ` Giedrius Statkevičius [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54BBCFE2.9030801@gmail.com \
--to=giedrius.statkevicius@gmail.com \
--cc=ahmad.hassan612@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=forest@alittletooquiet.net \
--cc=gclement@baobob.org \
--cc=gregkh@linuxfoundation.org \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tvboxspy@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox