* Re: [PATCH] staging: vt6655: fix space prohibted before that ',' Signed-off-by: Ahmadposten <ahmad.hassan612@gmail.com>
2015-01-18 23:38 [PATCH] staging: vt6655: fix space prohibted before that ',' Signed-off-by: Ahmadposten <ahmad.hassan612@gmail.com> Ahmadposten
@ 2015-01-18 15:23 ` Giedrius Statkevičius
0 siblings, 0 replies; 2+ messages in thread
From: Giedrius Statkevičius @ 2015-01-18 15:23 UTC (permalink / raw)
To: Ahmadposten, devel; +Cc: gclement, tvboxspy, gregkh, linux-kernel, forest, joe
On 2015.01.19 01:38, Ahmadposten wrote:
> ---
> drivers/staging/vt6655/device_main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
> index f5cc78e..34e3a76 100644
> --- a/drivers/staging/vt6655/device_main.c
> +++ b/drivers/staging/vt6655/device_main.c
> @@ -1090,7 +1090,7 @@ static irqreturn_t device_intr(int irq, void *dev_instance)
> // Must do this after doing rx/tx, cause ISR bit is slow
> // than RD/TD write back
> // update ISR counter
> - STAvUpdate802_11Counter(&pDevice->s802_11Counter, &pDevice->scStatistic , dwMIBCounter);
> + STAvUpdate802_11Counter(&pDevice->s802_11Counter, &pDevice->scStatistic, dwMIBCounter);
> while (pDevice->dwIsr != 0) {
> STAvUpdateIsrStatCounter(&pDevice->scStatistic, pDevice->dwIsr);
> MACvWriteISR(pDevice->PortOffset, pDevice->dwIsr);
>
Your subject is messed up. The Signed-off-by part should be in the
message before "---". Also, consider adding some text that describes
more precisely what you've changed. By the way, as a newbie you can
always send your patches to yourself before sending it off to a ML to
see if everything is okay.
--
Thanks,
Giedrius
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] staging: vt6655: fix space prohibted before that ',' Signed-off-by: Ahmadposten <ahmad.hassan612@gmail.com>
@ 2015-01-18 23:38 Ahmadposten
2015-01-18 15:23 ` Giedrius Statkevičius
0 siblings, 1 reply; 2+ messages in thread
From: Ahmadposten @ 2015-01-18 23:38 UTC (permalink / raw)
To: devel; +Cc: forest, gregkh, tvboxspy, gclement, joe, guido, devel,
linux-kernel
---
drivers/staging/vt6655/device_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/vt6655/device_main.c b/drivers/staging/vt6655/device_main.c
index f5cc78e..34e3a76 100644
--- a/drivers/staging/vt6655/device_main.c
+++ b/drivers/staging/vt6655/device_main.c
@@ -1090,7 +1090,7 @@ static irqreturn_t device_intr(int irq, void *dev_instance)
// Must do this after doing rx/tx, cause ISR bit is slow
// than RD/TD write back
// update ISR counter
- STAvUpdate802_11Counter(&pDevice->s802_11Counter, &pDevice->scStatistic , dwMIBCounter);
+ STAvUpdate802_11Counter(&pDevice->s802_11Counter, &pDevice->scStatistic, dwMIBCounter);
while (pDevice->dwIsr != 0) {
STAvUpdateIsrStatCounter(&pDevice->scStatistic, pDevice->dwIsr);
MACvWriteISR(pDevice->PortOffset, pDevice->dwIsr);
--
2.2.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-01-18 15:23 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-18 23:38 [PATCH] staging: vt6655: fix space prohibted before that ',' Signed-off-by: Ahmadposten <ahmad.hassan612@gmail.com> Ahmadposten
2015-01-18 15:23 ` Giedrius Statkevičius
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox