From: 敬锐 <micky_ching@realsil.com.cn>
To: Lee Jones <lee.jones@linaro.org>
Cc: "sameo@linux.intel.com" <sameo@linux.intel.com>,
"devel@linuxdriverproject.org" <devel@linuxdriverproject.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>,
"rogerable@realtek.com" <rogerable@realtek.com>,
王炜 <wei_wang@realsil.com.cn>
Subject: Re: [PATCH 01/10] mfd: rtsx: replace TAB by SPC after #define
Date: Mon, 19 Jan 2015 01:23:12 +0000 [thread overview]
Message-ID: <54BC5C80.5090109@realsil.com.cn> (raw)
In-Reply-To: <20150118123837.GR3574@x1>
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 12050 bytes --]
On 01/18/2015 08:39 PM, Lee Jones wrote:
> On Thu, 15 Jan 2015, micky_ching@realsil.com.cn wrote:
>
>> From: Micky Ching <micky_ching@realsil.com.cn>
>>
>> Re-format coding-style, using uniform SPC after "#define" keyword
>> instead of mixing using TAB and SPC.
> Tabs and spaces in this context usually have different meanings
> i.e. space after #define usually denotes that the following define is
> a register address, whereas a tab commonly describes a bit field.
>
> Please ensure you're not messing with these conventions. By the looks
> of it you are not, but I need you to confirm that you know what you're
> doing.
if using TAB describe a bit field, and define TAB length = 8 SPC,
the editor will not show any difference(if not highlight TAB/SPC).
And the mix is not to show difference between address and field.
so all replaced by space, and show difference by next patch(02/10).
>> Signed-off-by: Micky Ching <micky_ching@realsil.com.cn>
>> ---
>> include/linux/mfd/rtsx_pci.h | 254 +++++++++++++++++++++----------------------
>> 1 file changed, 127 insertions(+), 127 deletions(-)
>>
>> diff --git a/include/linux/mfd/rtsx_pci.h b/include/linux/mfd/rtsx_pci.h
>> index 0c12628..a9c2a14 100644
>> --- a/include/linux/mfd/rtsx_pci.h
>> +++ b/include/linux/mfd/rtsx_pci.h
>> @@ -175,9 +175,9 @@
>> /* CARD_SHARE_MODE */
>> #define CARD_SHARE_MASK 0x0F
>> #define CARD_SHARE_MULTI_LUN 0x00
>> -#define CARD_SHARE_NORMAL 0x00
>> -#define CARD_SHARE_48_SD 0x04
>> -#define CARD_SHARE_48_MS 0x08
>> +#define CARD_SHARE_NORMAL 0x00
>> +#define CARD_SHARE_48_SD 0x04
>> +#define CARD_SHARE_48_MS 0x08
>> /* CARD_SHARE_MODE for barossa */
>> #define CARD_SHARE_BAROSSA_SD 0x01
>> #define CARD_SHARE_BAROSSA_MS 0x02
>> @@ -249,76 +249,76 @@
>> #define CD_AUTO_DISABLE 0x40
>>
>> /* SD_STAT1 */
>> -#define SD_CRC7_ERR 0x80
>> -#define SD_CRC16_ERR 0x40
>> -#define SD_CRC_WRITE_ERR 0x20
>> -#define SD_CRC_WRITE_ERR_MASK 0x1C
>> -#define GET_CRC_TIME_OUT 0x02
>> -#define SD_TUNING_COMPARE_ERR 0x01
>> +#define SD_CRC7_ERR 0x80
>> +#define SD_CRC16_ERR 0x40
>> +#define SD_CRC_WRITE_ERR 0x20
>> +#define SD_CRC_WRITE_ERR_MASK 0x1C
>> +#define GET_CRC_TIME_OUT 0x02
>> +#define SD_TUNING_COMPARE_ERR 0x01
>>
>> /* SD_STAT2 */
>> -#define SD_RSP_80CLK_TIMEOUT 0x01
>> +#define SD_RSP_80CLK_TIMEOUT 0x01
>>
>> /* SD_BUS_STAT */
>> -#define SD_CLK_TOGGLE_EN 0x80
>> -#define SD_CLK_FORCE_STOP 0x40
>> -#define SD_DAT3_STATUS 0x10
>> -#define SD_DAT2_STATUS 0x08
>> -#define SD_DAT1_STATUS 0x04
>> -#define SD_DAT0_STATUS 0x02
>> -#define SD_CMD_STATUS 0x01
>> +#define SD_CLK_TOGGLE_EN 0x80
>> +#define SD_CLK_FORCE_STOP 0x40
>> +#define SD_DAT3_STATUS 0x10
>> +#define SD_DAT2_STATUS 0x08
>> +#define SD_DAT1_STATUS 0x04
>> +#define SD_DAT0_STATUS 0x02
>> +#define SD_CMD_STATUS 0x01
>>
>> /* SD_PAD_CTL */
>> -#define SD_IO_USING_1V8 0x80
>> -#define SD_IO_USING_3V3 0x7F
>> -#define TYPE_A_DRIVING 0x00
>> -#define TYPE_B_DRIVING 0x01
>> -#define TYPE_C_DRIVING 0x02
>> -#define TYPE_D_DRIVING 0x03
>> +#define SD_IO_USING_1V8 0x80
>> +#define SD_IO_USING_3V3 0x7F
>> +#define TYPE_A_DRIVING 0x00
>> +#define TYPE_B_DRIVING 0x01
>> +#define TYPE_C_DRIVING 0x02
>> +#define TYPE_D_DRIVING 0x03
>>
>> /* SD_SAMPLE_POINT_CTL */
>> -#define DDR_FIX_RX_DAT 0x00
>> -#define DDR_VAR_RX_DAT 0x80
>> -#define DDR_FIX_RX_DAT_EDGE 0x00
>> -#define DDR_FIX_RX_DAT_14_DELAY 0x40
>> -#define DDR_FIX_RX_CMD 0x00
>> -#define DDR_VAR_RX_CMD 0x20
>> -#define DDR_FIX_RX_CMD_POS_EDGE 0x00
>> -#define DDR_FIX_RX_CMD_14_DELAY 0x10
>> -#define SD20_RX_POS_EDGE 0x00
>> -#define SD20_RX_14_DELAY 0x08
>> +#define DDR_FIX_RX_DAT 0x00
>> +#define DDR_VAR_RX_DAT 0x80
>> +#define DDR_FIX_RX_DAT_EDGE 0x00
>> +#define DDR_FIX_RX_DAT_14_DELAY 0x40
>> +#define DDR_FIX_RX_CMD 0x00
>> +#define DDR_VAR_RX_CMD 0x20
>> +#define DDR_FIX_RX_CMD_POS_EDGE 0x00
>> +#define DDR_FIX_RX_CMD_14_DELAY 0x10
>> +#define SD20_RX_POS_EDGE 0x00
>> +#define SD20_RX_14_DELAY 0x08
>> #define SD20_RX_SEL_MASK 0x08
>>
>> /* SD_PUSH_POINT_CTL */
>> -#define DDR_FIX_TX_CMD_DAT 0x00
>> -#define DDR_VAR_TX_CMD_DAT 0x80
>> -#define DDR_FIX_TX_DAT_14_TSU 0x00
>> -#define DDR_FIX_TX_DAT_12_TSU 0x40
>> -#define DDR_FIX_TX_CMD_NEG_EDGE 0x00
>> -#define DDR_FIX_TX_CMD_14_AHEAD 0x20
>> -#define SD20_TX_NEG_EDGE 0x00
>> -#define SD20_TX_14_AHEAD 0x10
>> +#define DDR_FIX_TX_CMD_DAT 0x00
>> +#define DDR_VAR_TX_CMD_DAT 0x80
>> +#define DDR_FIX_TX_DAT_14_TSU 0x00
>> +#define DDR_FIX_TX_DAT_12_TSU 0x40
>> +#define DDR_FIX_TX_CMD_NEG_EDGE 0x00
>> +#define DDR_FIX_TX_CMD_14_AHEAD 0x20
>> +#define SD20_TX_NEG_EDGE 0x00
>> +#define SD20_TX_14_AHEAD 0x10
>> #define SD20_TX_SEL_MASK 0x10
>> -#define DDR_VAR_SDCLK_POL_SWAP 0x01
>> +#define DDR_VAR_SDCLK_POL_SWAP 0x01
>>
>> /* SD_TRANSFER */
>> -#define SD_TRANSFER_START 0x80
>> -#define SD_TRANSFER_END 0x40
>> +#define SD_TRANSFER_START 0x80
>> +#define SD_TRANSFER_END 0x40
>> #define SD_STAT_IDLE 0x20
>> -#define SD_TRANSFER_ERR 0x10
>> +#define SD_TRANSFER_ERR 0x10
>> /* SD Transfer Mode definition */
>> -#define SD_TM_NORMAL_WRITE 0x00
>> -#define SD_TM_AUTO_WRITE_3 0x01
>> -#define SD_TM_AUTO_WRITE_4 0x02
>> -#define SD_TM_AUTO_READ_3 0x05
>> -#define SD_TM_AUTO_READ_4 0x06
>> -#define SD_TM_CMD_RSP 0x08
>> -#define SD_TM_AUTO_WRITE_1 0x09
>> -#define SD_TM_AUTO_WRITE_2 0x0A
>> -#define SD_TM_NORMAL_READ 0x0C
>> -#define SD_TM_AUTO_READ_1 0x0D
>> -#define SD_TM_AUTO_READ_2 0x0E
>> -#define SD_TM_AUTO_TUNING 0x0F
>> +#define SD_TM_NORMAL_WRITE 0x00
>> +#define SD_TM_AUTO_WRITE_3 0x01
>> +#define SD_TM_AUTO_WRITE_4 0x02
>> +#define SD_TM_AUTO_READ_3 0x05
>> +#define SD_TM_AUTO_READ_4 0x06
>> +#define SD_TM_CMD_RSP 0x08
>> +#define SD_TM_AUTO_WRITE_1 0x09
>> +#define SD_TM_AUTO_WRITE_2 0x0A
>> +#define SD_TM_NORMAL_READ 0x0C
>> +#define SD_TM_AUTO_READ_1 0x0D
>> +#define SD_TM_AUTO_READ_2 0x0E
>> +#define SD_TM_AUTO_TUNING 0x0F
>>
>> /* SD_VPTX_CTL / SD_VPRX_CTL */
>> #define PHASE_CHANGE 0x80
>> @@ -332,15 +332,15 @@
>>
>> /* SD Configure 1 Register */
>> #define SD_CLK_DIVIDE_0 0x00
>> -#define SD_CLK_DIVIDE_256 0xC0
>> -#define SD_CLK_DIVIDE_128 0x80
>> -#define SD_BUS_WIDTH_1BIT 0x00
>> -#define SD_BUS_WIDTH_4BIT 0x01
>> -#define SD_BUS_WIDTH_8BIT 0x02
>> -#define SD_ASYNC_FIFO_NOT_RST 0x10
>> -#define SD_20_MODE 0x00
>> -#define SD_DDR_MODE 0x04
>> -#define SD_30_MODE 0x08
>> +#define SD_CLK_DIVIDE_256 0xC0
>> +#define SD_CLK_DIVIDE_128 0x80
>> +#define SD_BUS_WIDTH_1BIT 0x00
>> +#define SD_BUS_WIDTH_4BIT 0x01
>> +#define SD_BUS_WIDTH_8BIT 0x02
>> +#define SD_ASYNC_FIFO_NOT_RST 0x10
>> +#define SD_20_MODE 0x00
>> +#define SD_DDR_MODE 0x04
>> +#define SD_30_MODE 0x08
>>
>> #define SD_CLK_DIVIDE_MASK 0xC0
>>
>> @@ -415,71 +415,71 @@
>> #define CLK_DIV_8 0x04
>>
>> /* MS_CFG */
>> -#define SAMPLE_TIME_RISING 0x00
>> -#define SAMPLE_TIME_FALLING 0x80
>> -#define PUSH_TIME_DEFAULT 0x00
>> -#define PUSH_TIME_ODD 0x40
>> -#define NO_EXTEND_TOGGLE 0x00
>> -#define EXTEND_TOGGLE_CHK 0x20
>> -#define MS_BUS_WIDTH_1 0x00
>> -#define MS_BUS_WIDTH_4 0x10
>> -#define MS_BUS_WIDTH_8 0x18
>> -#define MS_2K_SECTOR_MODE 0x04
>> -#define MS_512_SECTOR_MODE 0x00
>> -#define MS_TOGGLE_TIMEOUT_EN 0x00
>> -#define MS_TOGGLE_TIMEOUT_DISEN 0x01
>> +#define SAMPLE_TIME_RISING 0x00
>> +#define SAMPLE_TIME_FALLING 0x80
>> +#define PUSH_TIME_DEFAULT 0x00
>> +#define PUSH_TIME_ODD 0x40
>> +#define NO_EXTEND_TOGGLE 0x00
>> +#define EXTEND_TOGGLE_CHK 0x20
>> +#define MS_BUS_WIDTH_1 0x00
>> +#define MS_BUS_WIDTH_4 0x10
>> +#define MS_BUS_WIDTH_8 0x18
>> +#define MS_2K_SECTOR_MODE 0x04
>> +#define MS_512_SECTOR_MODE 0x00
>> +#define MS_TOGGLE_TIMEOUT_EN 0x00
>> +#define MS_TOGGLE_TIMEOUT_DISEN 0x01
>> #define MS_NO_CHECK_INT 0x02
>>
>> /* MS_TRANS_CFG */
>> -#define WAIT_INT 0x80
>> -#define NO_WAIT_INT 0x00
>> -#define NO_AUTO_READ_INT_REG 0x00
>> -#define AUTO_READ_INT_REG 0x40
>> -#define MS_CRC16_ERR 0x20
>> -#define MS_RDY_TIMEOUT 0x10
>> -#define MS_INT_CMDNK 0x08
>> -#define MS_INT_BREQ 0x04
>> -#define MS_INT_ERR 0x02
>> -#define MS_INT_CED 0x01
>> +#define WAIT_INT 0x80
>> +#define NO_WAIT_INT 0x00
>> +#define NO_AUTO_READ_INT_REG 0x00
>> +#define AUTO_READ_INT_REG 0x40
>> +#define MS_CRC16_ERR 0x20
>> +#define MS_RDY_TIMEOUT 0x10
>> +#define MS_INT_CMDNK 0x08
>> +#define MS_INT_BREQ 0x04
>> +#define MS_INT_ERR 0x02
>> +#define MS_INT_CED 0x01
>>
>> /* MS_TRANSFER */
>> -#define MS_TRANSFER_START 0x80
>> -#define MS_TRANSFER_END 0x40
>> -#define MS_TRANSFER_ERR 0x20
>> -#define MS_BS_STATE 0x10
>> -#define MS_TM_READ_BYTES 0x00
>> -#define MS_TM_NORMAL_READ 0x01
>> -#define MS_TM_WRITE_BYTES 0x04
>> -#define MS_TM_NORMAL_WRITE 0x05
>> -#define MS_TM_AUTO_READ 0x08
>> -#define MS_TM_AUTO_WRITE 0x0C
>> +#define MS_TRANSFER_START 0x80
>> +#define MS_TRANSFER_END 0x40
>> +#define MS_TRANSFER_ERR 0x20
>> +#define MS_BS_STATE 0x10
>> +#define MS_TM_READ_BYTES 0x00
>> +#define MS_TM_NORMAL_READ 0x01
>> +#define MS_TM_WRITE_BYTES 0x04
>> +#define MS_TM_NORMAL_WRITE 0x05
>> +#define MS_TM_AUTO_READ 0x08
>> +#define MS_TM_AUTO_WRITE 0x0C
>>
>> /* SD Configure 2 Register */
>> -#define SD_CALCULATE_CRC7 0x00
>> -#define SD_NO_CALCULATE_CRC7 0x80
>> -#define SD_CHECK_CRC16 0x00
>> -#define SD_NO_CHECK_CRC16 0x40
>> +#define SD_CALCULATE_CRC7 0x00
>> +#define SD_NO_CALCULATE_CRC7 0x80
>> +#define SD_CHECK_CRC16 0x00
>> +#define SD_NO_CHECK_CRC16 0x40
>> #define SD_NO_CHECK_WAIT_CRC_TO 0x20
>> -#define SD_WAIT_BUSY_END 0x08
>> -#define SD_NO_WAIT_BUSY_END 0x00
>> -#define SD_CHECK_CRC7 0x00
>> -#define SD_NO_CHECK_CRC7 0x04
>> -#define SD_RSP_LEN_0 0x00
>> -#define SD_RSP_LEN_6 0x01
>> -#define SD_RSP_LEN_17 0x02
>> +#define SD_WAIT_BUSY_END 0x08
>> +#define SD_NO_WAIT_BUSY_END 0x00
>> +#define SD_CHECK_CRC7 0x00
>> +#define SD_NO_CHECK_CRC7 0x04
>> +#define SD_RSP_LEN_0 0x00
>> +#define SD_RSP_LEN_6 0x01
>> +#define SD_RSP_LEN_17 0x02
>> /* SD/MMC Response Type Definition */
>> -#define SD_RSP_TYPE_R0 0x04
>> -#define SD_RSP_TYPE_R1 0x01
>> -#define SD_RSP_TYPE_R1b 0x09
>> -#define SD_RSP_TYPE_R2 0x02
>> -#define SD_RSP_TYPE_R3 0x05
>> -#define SD_RSP_TYPE_R4 0x05
>> -#define SD_RSP_TYPE_R5 0x01
>> -#define SD_RSP_TYPE_R6 0x01
>> -#define SD_RSP_TYPE_R7 0x01
>> +#define SD_RSP_TYPE_R0 0x04
>> +#define SD_RSP_TYPE_R1 0x01
>> +#define SD_RSP_TYPE_R1b 0x09
>> +#define SD_RSP_TYPE_R2 0x02
>> +#define SD_RSP_TYPE_R3 0x05
>> +#define SD_RSP_TYPE_R4 0x05
>> +#define SD_RSP_TYPE_R5 0x01
>> +#define SD_RSP_TYPE_R6 0x01
>> +#define SD_RSP_TYPE_R7 0x01
>>
>> /* SD_CONFIGURE3 */
>> -#define SD_RSP_80CLK_TIMEOUT_EN 0x01
>> +#define SD_RSP_80CLK_TIMEOUT_EN 0x01
>>
>> /* Card Transfer Reset Register */
>> #define SPI_STOP 0x01
>> @@ -574,13 +574,13 @@
>>
>> #define SRCTL 0xFC13
>>
>> -#define DCM_DRP_CTL 0xFC23
>> -#define DCM_DRP_TRIG 0xFC24
>> -#define DCM_DRP_CFG 0xFC25
>> -#define DCM_DRP_WR_DATA_L 0xFC26
>> -#define DCM_DRP_WR_DATA_H 0xFC27
>> -#define DCM_DRP_RD_DATA_L 0xFC28
>> -#define DCM_DRP_RD_DATA_H 0xFC29
>> +#define DCM_DRP_CTL 0xFC23
>> +#define DCM_DRP_TRIG 0xFC24
>> +#define DCM_DRP_CFG 0xFC25
>> +#define DCM_DRP_WR_DATA_L 0xFC26
>> +#define DCM_DRP_WR_DATA_H 0xFC27
>> +#define DCM_DRP_RD_DATA_L 0xFC28
>> +#define DCM_DRP_RD_DATA_H 0xFC29
>> #define SD_VPCLK0_CTL 0xFC2A
>> #define SD_VPCLK1_CTL 0xFC2B
>> #define SD_DCMPS0_CTL 0xFC2C
ÿôèº{.nÇ+‰·Ÿ®‰†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a¢f£¢·hšïêÿ‘êçz_è®\x03(階ŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨èÚ&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥
next prev parent reply other threads:[~2015-01-19 1:23 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-15 11:18 [PATCH 00/10] mfd: rtsx: add support for new rts524A and rts525A micky_ching
2015-01-15 11:18 ` [PATCH 01/10] mfd: rtsx: replace TAB by SPC after #define micky_ching
2015-01-18 12:39 ` Lee Jones
2015-01-19 1:23 ` 敬锐 [this message]
2015-01-19 7:49 ` Lee Jones
2015-01-15 11:18 ` [PATCH 02/10] mfd: rtsx: place register address and values togather micky_ching
2015-01-18 12:35 ` Lee Jones
2015-01-15 11:19 ` [PATCH 03/10] mfd: rtsx: add debug info when access register failed micky_ching
2015-01-18 12:35 ` Lee Jones
2015-01-15 11:19 ` [PATCH 04/10] mfd: rtsx: update PETXCFG address micky_ching
2015-01-18 12:31 ` Lee Jones
2015-01-15 11:19 ` [PATCH 05/10] mfd: rtsx: update driving settings micky_ching
2015-01-18 12:32 ` Lee Jones
2015-01-15 11:19 ` [PATCH 06/10] mfd: rtsx: update phy register micky_ching
2015-01-18 12:29 ` Lee Jones
2015-01-19 1:55 ` 敬锐
2015-01-19 7:47 ` Lee Jones
2015-01-20 2:07 ` 敬锐
2015-01-20 9:45 ` Lee Jones
2015-01-15 11:19 ` [PATCH 07/10] mfd: rtsx: remove LCTLR defination micky_ching
2015-01-18 12:28 ` Lee Jones
2015-01-19 1:12 ` 敬锐
2015-01-19 8:06 ` Lee Jones
2015-01-15 11:19 ` [PATCH 08/10] mfd: rtsx: add support for rts524A micky_ching
2015-01-18 12:20 ` Lee Jones
2015-01-19 2:32 ` 敬锐
2015-01-19 2:36 ` 敬锐
2015-01-19 7:40 ` Lee Jones
2015-01-19 3:09 ` 敬锐
2015-01-19 7:38 ` Lee Jones
2015-01-15 11:19 ` [PATCH 09/10] mfd: rtsx: add support for rts525A micky_ching
2015-01-18 11:13 ` Lee Jones
2015-01-19 2:53 ` 敬锐
2015-01-19 7:41 ` Lee Jones
2015-01-15 11:19 ` [PATCH 10/10] mfd: rtsx: using pcr_dbg replace dev_dbg micky_ching
2015-01-18 10:43 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54BC5C80.5090109@realsil.com.cn \
--to=micky_ching@realsil.com.cn \
--cc=devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rogerable@realtek.com \
--cc=sameo@linux.intel.com \
--cc=wei_wang@realsil.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox