Re: [PATCH 08/10] mfd: rtsx: add support for rts524A

Lee Jones
2015-01-19T07:38:46Z

On Mon, 19 Jan 2015, 敬锐 wrote:

>
> On 01/18/2015 08:20 PM, Lee Jones wrote:
> >> +};
> >> >+
> >> >+void rts524a_init_params(struct rtsx_pcr *pcr)
> >> >+{
> >> >+ rts5249_init_params(pcr);
> >> >+
> >> >+ pcr->ops = &rts524a_pcr_ops;
> >> >+}
> > I see a couple of these now. Why don't you make 'ops' a parameter of
> > *_init_params().
> >
> *_init_params() is called from rtsx_pcr.c, and the ops parameter should
> be static, if we make ops as a parameter, the rts524a_pcr_ops defination
> should move to rtsx_pcr.c, not reasonable.

Fair enough.

--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog