From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752039AbbASOik (ORCPT ); Mon, 19 Jan 2015 09:38:40 -0500 Received: from cantor2.suse.de ([195.135.220.15]:56441 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751467AbbASOij (ORCPT ); Mon, 19 Jan 2015 09:38:39 -0500 Message-ID: <54BD16EA.9050007@suse.cz> Date: Mon, 19 Jan 2015 15:38:34 +0100 From: Vlastimil Babka User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 MIME-Version: 1.0 To: Michal Hocko , akpm@linux-foundation.org, Joonsoo Kim CC: mm-commits@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, linux-next@vger.kernel.org, sfr@canb.auug.org.au Subject: Re: compaction tracepoint broken with CONFIG_COMPACTION enabled References: <54b9a3ce.lQ94nh84G4XJawsQ%akpm@linux-foundation.org> <20150119124210.GC21052@dhcp22.suse.cz> In-Reply-To: <20150119124210.GC21052@dhcp22.suse.cz> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/19/2015 01:42 PM, Michal Hocko wrote: > Hi, > compaction trace points seem to be broken without CONFIG_COMPACTION > enabled after > mm-compaction-more-trace-to-understand-when-why-compaction-start-finish.patch. > > My config is > # CONFIG_COMPACTION is not set > CONFIG_CMA=y Joonsoo posted a V4 that should be fixed at least according to description - unfortunately it wasn't just fixes on top of what's in mmotm, though. > which might be a bit unusual but I am getting > CC mm/compaction.o > In file included from include/trace/define_trace.h:90:0, > from include/trace/events/compaction.h:298, > from mm/compaction.c:49: > include/trace/events/compaction.h: In function ‘ftrace_raw_output_mm_compaction_end’: > include/trace/events/compaction.h:164:3: error: ‘compaction_status_string’ undeclared (first use in this function) > compaction_status_string[__entry->status]) > ^ > [...] > include/trace/events/compaction.h: In function ‘ftrace_raw_output_mm_compaction_suitable_template’: > include/trace/events/compaction.h:220:3: error: ‘compaction_status_string’ undeclared (first use in this function) > compaction_status_string[__entry->ret]) > [...] > scripts/Makefile.build:257: recipe for target 'mm/compaction.o' failed > make[1]: *** [mm/compaction.o] Error 1 > Makefile:1528: recipe for target 'mm/compaction.o' failed > make: *** [mm/compaction.o] Error 2 > > Moving compaction_status_string outside of CONFIG_COMPACTION doesn't > help much because of other failures: > include/trace/events/compaction.h:261:30: error: ‘struct zone’ has no member named ‘compact_defer_shift’ > __entry->defer_shift = zone->compact_defer_shift; > > So I guess the tracepoint need a better fix. >