From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752293AbbASPOn (ORCPT ); Mon, 19 Jan 2015 10:14:43 -0500 Received: from mail-la0-f51.google.com ([209.85.215.51]:43365 "EHLO mail-la0-f51.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751341AbbASPOl (ORCPT ); Mon, 19 Jan 2015 10:14:41 -0500 Message-ID: <54BD1F56.1010209@gmail.com> Date: Mon, 19 Jan 2015 18:14:30 +0300 From: Dmitry Osipenko User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Thierry Reding CC: Stephen Warren , Alexandre Courbot , Peter De Schrijver , linux-tegra@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH] ARM: tegra20: Store CPU "resettable" status in IRAM References: <1421319545-23920-1-git-send-email-digetx@gmail.com> <1421319545-23920-2-git-send-email-digetx@gmail.com> <20150119141224.GF23778@ulmo.nvidia.com> In-Reply-To: <20150119141224.GF23778@ulmo.nvidia.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 19.01.2015 17:12, Thierry Reding пишет: > On Thu, Jan 15, 2015 at 01:58:57PM +0300, Dmitry Osipenko wrote: >> Commit 7232398abc6a ("ARM: tegra: Convert PMC to a driver") changed tegra_resume() >> location storing from late to early and, as a result, broke suspend on Tegra20. >> PMC scratch register 41 is used by tegra LP1 resume code for retrieving stored >> physical memory address of common resume function and in the same time used by >> tegra20_cpu_shutdown() (shared by Tegra20 cpuidle driver and platform SMP code), >> which is storing CPU1 "resettable" status. It implies strict order of scratch >> register usage, otherwise resume function address is lost on Tegra20 after >> disabling non-boot CPU's on suspend. Fix it by storing "resettable" status in >> IRAM instead of PMC scratch register. >> >> Signed-off-by: Dmitry Osipenko >> Fixes: 7232398abc6a (ARM: tegra: Convert PMC to a driver) >> Cc: # v3.17+ >> --- >> arch/arm/mach-tegra/cpuidle-tegra20.c | 5 ++--- >> arch/arm/mach-tegra/reset-handler.S | 10 +++++++--- >> arch/arm/mach-tegra/reset.h | 4 ++++ >> arch/arm/mach-tegra/sleep-tegra20.S | 37 ++++++++++++++++++++--------------- >> arch/arm/mach-tegra/sleep.h | 4 ++++ >> 5 files changed, 38 insertions(+), 22 deletions(-) > > I'm leaning towards applying this. Stephen, Alex, Peter: any objections? > > Thierry > Btw, I'm preparing cleanup for cpuidle and hotplug code. So this asm "ugliness" should go away. -- Dmitry