* [PATCH] ARM: OMAP: DRA7: hwmod: Make gpmc software supervised as the smart idle is broken
@ 2015-01-13 8:51 Keerthy
2015-01-20 6:23 ` Keerthy
0 siblings, 1 reply; 3+ messages in thread
From: Keerthy @ 2015-01-13 8:51 UTC (permalink / raw)
To: tony; +Cc: t-kristo, linux-omap, linux-kernel, linux, Keerthy
This patch fixes: 'omap_hwmod: gpmc: _wait_target_disable failed'
error during suspend.
This is because smart idle is broken.
Tested in dra7-evm D1 board.
Signed-off-by: Keerthy <j-keerthy@ti.com>
---
arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
index 9cdd8b8..29e55fe 100644
--- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
@@ -826,7 +826,8 @@ static struct omap_hwmod dra7xx_gpmc_hwmod = {
.name = "gpmc",
.class = &dra7xx_gpmc_hwmod_class,
.clkdm_name = "l3main1_clkdm",
- .flags = HWMOD_INIT_NO_IDLE | HWMOD_INIT_NO_RESET,
+ .flags = (HWMOD_INIT_NO_IDLE | HWMOD_INIT_NO_RESET |
+ HWMOD_SWSUP_SIDLE),
.main_clk = "l3_iclk_div",
.prcm = {
.omap4 = {
--
1.7.9.5
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: OMAP: DRA7: hwmod: Make gpmc software supervised as the smart idle is broken
2015-01-13 8:51 [PATCH] ARM: OMAP: DRA7: hwmod: Make gpmc software supervised as the smart idle is broken Keerthy
@ 2015-01-20 6:23 ` Keerthy
2015-01-20 7:23 ` Paul Walmsley
0 siblings, 1 reply; 3+ messages in thread
From: Keerthy @ 2015-01-20 6:23 UTC (permalink / raw)
To: tony; +Cc: t-kristo, linux-omap, linux-kernel, linux
Hi Tony,
On Tuesday 13 January 2015 02:21 PM, Keerthy wrote:
> This patch fixes: 'omap_hwmod: gpmc: _wait_target_disable failed'
> error during suspend.
>
> This is because smart idle is broken.
> Tested in dra7-evm D1 board.
Ping on this.
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
> arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> index 9cdd8b8..29e55fe 100644
> --- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> +++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> @@ -826,7 +826,8 @@ static struct omap_hwmod dra7xx_gpmc_hwmod = {
> .name = "gpmc",
> .class = &dra7xx_gpmc_hwmod_class,
> .clkdm_name = "l3main1_clkdm",
> - .flags = HWMOD_INIT_NO_IDLE | HWMOD_INIT_NO_RESET,
> + .flags = (HWMOD_INIT_NO_IDLE | HWMOD_INIT_NO_RESET |
> + HWMOD_SWSUP_SIDLE),
> .main_clk = "l3_iclk_div",
> .prcm = {
> .omap4 = {
Regards,
Keerthy
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ARM: OMAP: DRA7: hwmod: Make gpmc software supervised as the smart idle is broken
2015-01-20 6:23 ` Keerthy
@ 2015-01-20 7:23 ` Paul Walmsley
0 siblings, 0 replies; 3+ messages in thread
From: Paul Walmsley @ 2015-01-20 7:23 UTC (permalink / raw)
To: Keerthy; +Cc: tony, t-kristo, linux-omap, linux-kernel, linux
On Tue, 20 Jan 2015, Keerthy wrote:
> On Tuesday 13 January 2015 02:21 PM, Keerthy wrote:
> > This patch fixes: 'omap_hwmod: gpmc: _wait_target_disable failed'
> > error during suspend.
> >
> > This is because smart idle is broken.
> > Tested in dra7-evm D1 board.
>
> Ping on this.
>
> > Signed-off-by: Keerthy <j-keerthy@ti.com>
> > ---
> > arch/arm/mach-omap2/omap_hwmod_7xx_data.c | 3 ++-
> > 1 file changed, 2 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> > b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> > index 9cdd8b8..29e55fe 100644
> > --- a/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> > +++ b/arch/arm/mach-omap2/omap_hwmod_7xx_data.c
> > @@ -826,7 +826,8 @@ static struct omap_hwmod dra7xx_gpmc_hwmod = {
> > .name = "gpmc",
> > .class = &dra7xx_gpmc_hwmod_class,
> > .clkdm_name = "l3main1_clkdm",
> > - .flags = HWMOD_INIT_NO_IDLE | HWMOD_INIT_NO_RESET,
> > + .flags = (HWMOD_INIT_NO_IDLE | HWMOD_INIT_NO_RESET |
> > + HWMOD_SWSUP_SIDLE),
> > .main_clk = "l3_iclk_div",
> > .prcm = {
> > .omap4 = {
Thanks, queued for v3.20.
Note that I cannot test this since I don't have a DRA7xx board.
- Paul
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-01-20 7:25 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-13 8:51 [PATCH] ARM: OMAP: DRA7: hwmod: Make gpmc software supervised as the smart idle is broken Keerthy
2015-01-20 6:23 ` Keerthy
2015-01-20 7:23 ` Paul Walmsley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox