public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: "Noralf Trønnes" <notro@tronnes.org>
To: Paul Bolle <pebolle@tiscali.nl>,
	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Cc: Valentin Rothberg <valentinrothberg@gmail.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org
Subject: Re: staging: fbtft: CONFIG_ARCH_BCM2708?
Date: Tue, 20 Jan 2015 12:11:26 +0100	[thread overview]
Message-ID: <54BE37DE.9020700@tronnes.org> (raw)
In-Reply-To: <1421743602.9655.83.camel@x220>

Den 20.01.2015 09:46, skrev Paul Bolle:
> Thomas, Noralf,
>
> Your commit c296d5f9957c ("staging: fbtft: core support") is included in
> today's linux-next (ie, next-20150120). I noticed because a script I use
> to check linux-next spotted a problem in it.
>
> See, that commit adds two checks for CONFIG_ARCH_BCM2708. But there's no
> Kconfig symbol ARCH_BCM2708. (A comment in
> drivers/mmc/host/sdhci-bcm2835.c does suggest there's an out of tree
> "Main bcm2708 linux port".)
>
> Is the code to add the Kconfig symbol ARCH_BCM2708 queued somewhere?
Hi Paul,

ARCH_BCM2708 is used instead of ARCH_BCM2835 in the Raspberry Pi kernel 
fork.
The optimization code enabled by ARCH_BCM2708 in 
drivers/staging/fbtft/fbtft-io.c can be removed.
There will be another take on the I/O stage for those drivers later.

I can make a patch for this. Just need to find out how to setup git to 
send paches for me.

Thanks for spotting this.


Noralf.


      reply	other threads:[~2015-01-20 11:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-20  8:46 staging: fbtft: CONFIG_ARCH_BCM2708? Paul Bolle
2015-01-20 11:11 ` Noralf Trønnes [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=54BE37DE.9020700@tronnes.org \
    --to=notro@tronnes.org \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pebolle@tiscali.nl \
    --cc=thomas.petazzoni@free-electrons.com \
    --cc=valentinrothberg@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox