From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752517AbbATOgd (ORCPT ); Tue, 20 Jan 2015 09:36:33 -0500 Received: from mailout3.w1.samsung.com ([210.118.77.13]:46834 "EHLO mailout3.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750777AbbATOgb (ORCPT ); Tue, 20 Jan 2015 09:36:31 -0500 X-AuditID: cbfec7f4-b7f126d000001e9a-68-54be67ec5935 Message-id: <54BE67EA.2070507@samsung.com> Date: Tue, 20 Jan 2015 15:36:26 +0100 From: Jacek Anaszewski User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804 Thunderbird/17.0.8 MIME-version: 1.0 To: Lee Jones Cc: linux-leds@vger.kernel.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, kyungmin.park@samsung.com, b.zolnierkie@samsung.com, pavel@ucw.cz, cooloney@gmail.com, rpurdie@rpsys.net, sakari.ailus@iki.fi, s.nawrocki@samsung.com, Andrzej Hajda , Chanwoo Choi , Rob Herring , Pawel Moll , Mark Rutland , Ian Campbell , Kumar Gala Subject: Re: [PATCH/RFC v10 09/19] DT: Add documentation for the mfd Maxim max77693 References: <1420816989-1808-1-git-send-email-j.anaszewski@samsung.com> <1420816989-1808-10-git-send-email-j.anaszewski@samsung.com> <20150120112107.GG13701@x1> In-reply-to: <20150120112107.GG13701@x1> Content-type: text/plain; charset=UTF-8; format=flowed Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprOIsWRmVeSWpSXmKPExsVy+t/xy7pv0veFGCxpZ7O4te4cq8XGGetZ LY7unMhkcf3Lc1aL+UeAYv1vFrJanHu1ktHibNMbdov7X48yWlzeNYfNYuubdYwWPRu2slos vX6RyeLuqaNsFhOmr2WxaN17hN1i966nrBaH37SzWpzZv5LNQdhjzbw1jB6X+3qZPHbOusvu sXL5FzaPw18XsnhsWtXJ5nHn2h42jz3zf7B69G1ZxeixYvV3do/Pm+QCuKO4bFJSczLLUov0 7RK4Mj7OCS34K1Wx4+AW9gbGWWJdjJwcEgImEj877jNC2GISF+6tZ+ti5OIQEljKKPH04CQm COcjo0Tv3iesIFW8AloSGw49YAKxWQRUJZou32AHsdkEDCV+vngNFhcViJD4c3ofVL2gxI/J 91i6GDk4RARUJM69MQeZySwwj0ViW990NpAaYYFQiTk9F5lBbCGBJYwSff2eIDangIZEy7l3 YDOZBcwkHrWsY4aw5SU2r3nLPIFRYBaSFbOQlM1CUraAkXkVo2hqaXJBcVJ6rqFecWJucWle ul5yfu4mRkhkftnBuPiY1SFGAQ5GJR5ejZw9IUKsiWXFlbmHGCU4mJVEeM+a7wsR4k1JrKxK LcqPLyrNSS0+xMjEwSnVwLhMtTgopZZjg/Teor13nK7sO/aqzs18PtN1kxl39t+xkf5d6TpB belM6XNin1KUpB1nFH0q9dL2+KkrVDuL67D8beGXxlfLvdLfsD69O+lc2KJFDKVSO+7tPOOX HHlkS9++nM7C3NKYgvNHE03SVn1ec+q/olZf0R6PnR+q/k526J9v3OL7oEaJpTgj0VCLuag4 EQB65snOqgIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/20/2015 12:21 PM, Lee Jones wrote: > On Fri, 09 Jan 2015, Jacek Anaszewski wrote: > >> This patch adds device tree binding documentation for >> the flash cell of the Maxim max77693 multifunctional device. >> >> Signed-off-by: Jacek Anaszewski >> Signed-off-by: Andrzej Hajda >> Acked-by: Kyungmin Park >> Cc: Lee Jones >> Cc: Chanwoo Choi >> Cc: Bryan Wu >> Cc: Richard Purdie >> Cc: Rob Herring >> Cc: Pawel Moll >> Cc: Mark Rutland >> Cc: Ian Campbell >> Cc: Kumar Gala >> --- >> Documentation/devicetree/bindings/mfd/max77693.txt | 69 ++++++++++++++++++++ >> 1 file changed, 69 insertions(+) >> >> diff --git a/Documentation/devicetree/bindings/mfd/max77693.txt b/Documentation/devicetree/bindings/mfd/max77693.txt >> index 01e9f30..ef184f0 100644 >> --- a/Documentation/devicetree/bindings/mfd/max77693.txt >> +++ b/Documentation/devicetree/bindings/mfd/max77693.txt >> @@ -41,7 +41,52 @@ Optional properties: >> To get more informations, please refer to documentaion. >> [*] refer Documentation/devicetree/bindings/pwm/pwm.txt >> >> +- led : the LED submodule device node >> + >> +There are two led outputs available - fled1 and fled2. Each of them can >> +control a separate led or they can be connected together to double >> +the maximum current for a single connected led. One led is represented >> +by one child node. >> + >> +Required properties: >> +- compatible : Must be "maxim,max77693-led". >> + >> +Optional properties: >> +- maxim,trigger-type : Flash trigger type. >> + Possible trigger types: >> + MAX77693_LED_TRIG_TYPE_EDGE - Rising edge of the signal triggers >> + the flash, >> + MAX77693_LED_TRIG_TYPE_LEVEL - Strobe pulse length controls >> + duration of the flash. > > I think you should represent the proper values here instead of the > defines. I see both versions in the existing bindings and also a combination of them, e.g.: MAX77693_LED_TRIG_TYPE_EDGE (0). I think that it is reasonable to mention the macros, especially if they are to appear in the DT binding example at the end of the documentation file. >> +- maxim,boost-mode : >> + In boost mode the device can produce up to 1.2A of total current >> + on both outputs. The maximum current on each output is reduced >> + to 625mA then. If not enabled explicitly, boost setting defaults to >> + MAX77693_LED_BOOST_FIXED in case both current sources are used. >> + Possible values: >> + MAX77693_LED_BOOST_OFF - no boost, >> + MAX77693_LED_BOOST_ADAPTIVE - adaptive mode, >> + MAX77693_LED_BOOST_FIXED - fixed mode. > > Same here. MAX77693_LED_BOOST_OFF (0) - no boost, MAX77693_LED_BOOST_ADAPTIVE (1) - adaptive mode, MAX77693_LED_BOOST_FIXED (2) - fixed mode. ? > >> +- maxim,boost-vout : Output voltage of the boost module in millivolts. > > -mvout? > -microvout? maxim,boost-mvout ? >> +- maxim,vsys-min : Low input voltage level in millivolts. Flash is not fired >> + if chip estimates that system voltage could drop below this level due >> + to flash power consumption. > > mvsys? > microvsys? maxim,mvsys-min ? -- Best Regards, Jacek Anaszewski