From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753663AbbAUECL (ORCPT ); Tue, 20 Jan 2015 23:02:11 -0500 Received: from bh-25.webhostbox.net ([208.91.199.152]:49401 "EHLO bh-25.webhostbox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752455AbbAUECG (ORCPT ); Tue, 20 Jan 2015 23:02:06 -0500 Message-ID: <54BF2496.4000807@roeck-us.net> Date: Tue, 20 Jan 2015 20:01:26 -0800 From: Guenter Roeck User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Al Viro CC: Paul Moore , Sabrina Dubroca , Stephen Rothwell , linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-audit@redhat.com, Richard Guy Briggs Subject: Re: linux-next: Tree for Jan 20 -- Kernel panic - Unable to mount root fs References: <20150120165655.GA10904@kria> <20150120232726.GA16913@kria> <1517211.UYLV49hvpg@sifl> <1528536.jyty2pu4Mz@sifl> <20150121004117.GM29656@ZenIV.linux.org.uk> <54BF1292.2080902@roeck-us.net> <20150121033600.GN29656@ZenIV.linux.org.uk> In-Reply-To: <20150121033600.GN29656@ZenIV.linux.org.uk> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Authenticated_sender: linux@roeck-us.net X-OutGoing-Spam-Status: No, score=-1.0 X-CTCH-PVer: 0000001 X-CTCH-Spam: Unknown X-CTCH-VOD: Unknown X-CTCH-Flags: 0 X-CTCH-RefID: str=0001.0A020203.54BF24BD.0058,ss=1,re=0.001,recu=0.000,reip=0.000,cl=1,cld=1,fgs=0 X-CTCH-Score: 0.001 X-CTCH-ScoreCust: 0.000 X-CTCH-Rules: C_4847, X-CTCH-SenderID: linux@roeck-us.net X-CTCH-SenderID-Flags: 0 X-CTCH-SenderID-TotalMessages: 4 X-CTCH-SenderID-TotalSpam: 0 X-CTCH-SenderID-TotalSuspected: 0 X-CTCH-SenderID-TotalConfirmed: 0 X-CTCH-SenderID-TotalBulk: 0 X-CTCH-SenderID-TotalVirus: 0 X-CTCH-SenderID-TotalRecipients: 0 X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - bh-25.webhostbox.net X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - roeck-us.net X-Get-Message-Sender-Via: bh-25.webhostbox.net: mailgid no entry from get_relayhosts_entry X-Source: X-Source-Args: X-Source-Dir: Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 01/20/2015 07:36 PM, Al Viro wrote: > On Tue, Jan 20, 2015 at 06:44:34PM -0800, Guenter Roeck wrote: >>> The shit hits the fan earlier - when we end up missing /dev. There are >>> two places where it could've been created (depending on CONFIG_BLK_DEV_INITRD); >>> sys_mkdir(collected, mode); >>> in init/initramfs.c (line 353 in linux-next) and >>> err = sys_mkdir((const char __user __force *) "/dev", 0755); >>> in init/noinitramfs.c (line 32). The latter would've screamed on failure; >>> could you printk of collected (%s), mode (%o) and return value (%d) in the >>> former and see what happens? >>> >> >> sys_mkdir .:40775 returned -17 >> sys_mkdir usr:40775 returned 0 >> sys_mkdir usr/lib:40775 returned -2 >> sys_mkdir usr/share:40755 returned -2 >> sys_mkdir usr/share/udhcpc:40755 returned -2 >> sys_mkdir usr/bin:40775 returned -2 >> sys_mkdir usr/sbin:40775 returned -2 >> sys_mkdir mnt:40775 returned 0 >> sys_mkdir proc:40775 returned 0 >> sys_mkdir root:40775 returned 0 >> sys_mkdir lib:40775 returned 0 >> sys_mkdir lib/modules:40775 returned -2 >> sys_mkdir lib/modules/3.9.2:40775 returned -2 >> sys_mkdir lib/modules/3.9.2/kernel:40775 returned -2 >> >> with >> int err = sys_mkdir(collected, mode); >> pr_info("sys_mkdir %s:%o returned %d\n", collected, mode, err); >> added in init/initramfs.c. > > Just what is lib/modules/3.9.2 doing there? In any case, I think I have at Artifact from when I created the root file system (which apparently was with 3.9.2). It is irrelevant for my testing, at least so far, so I never bothered fixing it. > least a plausible direction for digging. Look: > > diff --git a/fs/namei.c b/fs/namei.c > index 323957f..c7d107c 100644 > --- a/fs/namei.c > +++ b/fs/namei.c With this patch: sys_mkdir .:40775 returned -17 sys_mkdir usr:40775 returned 0 sys_mkdir usr/lib:40775 returned 0 sys_mkdir usr/share:40755 returned 0 sys_mkdir usr/share/udhcpc:40755 returned 0 sys_mkdir usr/bin:40775 returned 0 sys_mkdir usr/sbin:40775 returned 0 sys_mkdir mnt:40775 returned 0 sys_mkdir proc:40775 returned 0 sys_mkdir root:40775 returned 0 sys_mkdir lib:40775 returned 0 sys_mkdir lib/modules:40775 returned 0 ... and the problem is fixed. Guenter