* [PATCH] crypto: caam - don't emit ICV check failures to dmesg [not found] ` <20141211193018.2465016d545334a76c0f4bab@freescale.com> @ 2015-01-20 18:43 ` Kim Phillips 2015-01-21 8:57 ` Cristian Stoica 0 siblings, 1 reply; 3+ messages in thread From: Kim Phillips @ 2015-01-20 18:43 UTC (permalink / raw) To: Herbert Xu Cc: Tudor Ambarus, linux-crypto, David S. Miller, Marek Vasut, Cristian Stoica, Horia Geanta, linux-kernel ICV check failures are part of normal operation; leave user notification up to the higher levels, as is done in s/w algorithm implementations. Signed-off-by: Kim Phillips <kim.phillips@freescale.com> --- drivers/crypto/caam/error.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/crypto/caam/error.c b/drivers/crypto/caam/error.c index 66d73bf..33e41ea 100644 --- a/drivers/crypto/caam/error.c +++ b/drivers/crypto/caam/error.c @@ -151,10 +151,15 @@ static void report_ccb_status(struct device *jrdev, const u32 status, else snprintf(err_err_code, sizeof(err_err_code), "%02x", err_id); - dev_err(jrdev, "%08x: %s: %s %d: %s%s: %s%s\n", - status, error, idx_str, idx, - cha_str, cha_err_code, - err_str, err_err_code); + /* + * CCB ICV check failures are part of normal operation life; + * we leave the upper layers to do what they want with them. + */ + if (err_id != JRSTA_CCBERR_ERRID_ICVCHK) + dev_err(jrdev, "%08x: %s: %s %d: %s%s: %s%s\n", + status, error, idx_str, idx, + cha_str, cha_err_code, + err_str, err_err_code); } static void report_jump_status(struct device *jrdev, const u32 status, -- 2.2.2 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] crypto: caam - don't emit ICV check failures to dmesg 2015-01-20 18:43 ` [PATCH] crypto: caam - don't emit ICV check failures to dmesg Kim Phillips @ 2015-01-21 8:57 ` Cristian Stoica 2015-01-26 2:55 ` Herbert Xu 0 siblings, 1 reply; 3+ messages in thread From: Cristian Stoica @ 2015-01-21 8:57 UTC (permalink / raw) To: Kim Phillips, Herbert Xu Cc: Tudor Ambarus, linux-crypto, David S. Miller, Marek Vasut, Horia Geanta, linux-kernel Hi Kim, On 01/20/2015 08:43 PM, Kim Phillips wrote: > ICV check failures are part of normal operation; > leave user notification up to the higher levels, > as is done in s/w algorithm implementations. > Tested on P4080DS. Tested-by: Cristian Stoica <cristian.stoica@freescale.com> Thanks, Cristian S. ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] crypto: caam - don't emit ICV check failures to dmesg 2015-01-21 8:57 ` Cristian Stoica @ 2015-01-26 2:55 ` Herbert Xu 0 siblings, 0 replies; 3+ messages in thread From: Herbert Xu @ 2015-01-26 2:55 UTC (permalink / raw) To: Cristian Stoica Cc: Kim Phillips, Tudor Ambarus, linux-crypto, David S. Miller, Marek Vasut, Horia Geanta, linux-kernel On Wed, Jan 21, 2015 at 10:57:32AM +0200, Cristian Stoica wrote: > Hi Kim, > > On 01/20/2015 08:43 PM, Kim Phillips wrote: > > ICV check failures are part of normal operation; > > leave user notification up to the higher levels, > > as is done in s/w algorithm implementations. > > > > Tested on P4080DS. > > Tested-by: Cristian Stoica <cristian.stoica@freescale.com> Applied. -- Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2015-01-26 2:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <1414686811-6527-1-git-send-email-tudor.ambarus@freescale.com>
[not found] ` <1414688107-8196-1-git-send-email-tudor.ambarus@freescale.com>
[not found] ` <20141106151714.GE4544@gondor.apana.org.au>
[not found] ` <20141204182245.f352ea22dc61ea6f65d85c62@freescale.com>
[not found] ` <20141211193018.2465016d545334a76c0f4bab@freescale.com>
2015-01-20 18:43 ` [PATCH] crypto: caam - don't emit ICV check failures to dmesg Kim Phillips
2015-01-21 8:57 ` Cristian Stoica
2015-01-26 2:55 ` Herbert Xu
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox