From: Paolo Bonzini <pbonzini@redhat.com>
To: Wincy Van <fanwenyi0529@gmail.com>,
"Zhang, Yang Z" <yang.z.zhang@intel.com>
Cc: "gleb@kernel.org" <gleb@kernel.org>,
"kvm@vger.kernel.org" <kvm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Wanpeng Li <wanpeng.li@linux.intel.com>,
Jan Kiszka <jan.kiszka@web.de>
Subject: Re: [PATCH 1/5] KVM: nVMX: Make nested control MSRs per-cpu.
Date: Wed, 21 Jan 2015 11:21:06 +0100 [thread overview]
Message-ID: <54BF7D92.6020409@redhat.com> (raw)
In-Reply-To: <CACzj_yW056JWb_+SbdQpfRfqJEUoWk4bRmGjnDOm18UgEzHwYA@mail.gmail.com>
On 21/01/2015 10:23, Wincy Van wrote:
> Yes, moving that msrs looks a bit ugly, but the irqchip_in_kernel is
> per-VM, not a global
> setting, there would be different settings of kernel_irqchip between VMs.
> If we use irqchip_in_kernel to check it and set different value of the
> ctl msrs, I think it may
> be even worse than moving the msrs, because this logic should be a
> init function, and this
> setting should be converged.
I too prefer your solution.
Paolo
prev parent reply other threads:[~2015-01-21 10:21 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-16 5:50 [PATCH 1/5] KVM: nVMX: Make nested control MSRs per-cpu Wincy Van
2015-01-21 8:18 ` Zhang, Yang Z
2015-01-21 9:23 ` Wincy Van
2015-01-21 10:21 ` Paolo Bonzini [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54BF7D92.6020409@redhat.com \
--to=pbonzini@redhat.com \
--cc=fanwenyi0529@gmail.com \
--cc=gleb@kernel.org \
--cc=jan.kiszka@web.de \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=wanpeng.li@linux.intel.com \
--cc=yang.z.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox