From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752227AbbAUKVv (ORCPT ); Wed, 21 Jan 2015 05:21:51 -0500 Received: from mx1.redhat.com ([209.132.183.28]:42484 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750916AbbAUKVo (ORCPT ); Wed, 21 Jan 2015 05:21:44 -0500 Message-ID: <54BF7D92.6020409@redhat.com> Date: Wed, 21 Jan 2015 11:21:06 +0100 From: Paolo Bonzini User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0 MIME-Version: 1.0 To: Wincy Van , "Zhang, Yang Z" CC: "gleb@kernel.org" , "kvm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , Wanpeng Li , Jan Kiszka Subject: Re: [PATCH 1/5] KVM: nVMX: Make nested control MSRs per-cpu. References: In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/01/2015 10:23, Wincy Van wrote: > Yes, moving that msrs looks a bit ugly, but the irqchip_in_kernel is > per-VM, not a global > setting, there would be different settings of kernel_irqchip between VMs. > If we use irqchip_in_kernel to check it and set different value of the > ctl msrs, I think it may > be even worse than moving the msrs, because this logic should be a > init function, and this > setting should be converged. I too prefer your solution. Paolo