From: Peter Hung <hpeter@gmail.com>
To: One Thousand Gnomes <gnomes@lxorguk.ukuu.org.uk>
Cc: johan@kernel.org, gregkh@linuxfoundation.org,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
tom_tsai@fintek.com.tw, peter_hong@fintek.com.tw,
Peter Hung <hpeter+linux_kernel@gmail.com>
Subject: Re: [PATCH v2 3/4] usb: serial: implement function for F81232
Date: Thu, 22 Jan 2015 11:38:32 +0800 [thread overview]
Message-ID: <54C070B8.2040301@gmail.com> (raw)
In-Reply-To: <20150121144136.31f328cf@lxorguk.ukuu.org.uk>
Hello,
I'll do it later depend on this series patchs to be accpeted or rejected.
Thanks for your advice
One Thousand Gnomes 於 2015/1/21 下午 10:41 寫道:
>
>> + if (cflag & PARENB) {
>> + if (cflag & PARODD)
>> + new_lcr |= UART_LCR_PARITY; /* odd */
>> + else
>> + new_lcr |= SERIAL_EVEN_PARITY; /* even */
>> + }
>
> If you don't support mark/space also clear CMSPAR in the passed termios
>
>> - if (old_termios)
>> - tty_termios_copy_hw(&tty->termios, old_termios);
>
> Also when you set the baud rate compute the resulting actual baud rate
> you generated and set it with
>
> /* Don't rewrite B0 */
> if (tty_termios_baud_rate(termios))
> tty_termios_encode_baud_rate(termios, baud, baud);
>
> so that the application gets told the baud rate it actually got if it
> isn't close to the one they requested.
>
> Alan
>
prev parent reply other threads:[~2015-01-22 3:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-21 10:30 [PATCH v2 3/4] usb: serial: implement function for F81232 Peter Hung
2015-01-21 14:41 ` One Thousand Gnomes
2015-01-22 3:38 ` Peter Hung [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C070B8.2040301@gmail.com \
--to=hpeter@gmail.com \
--cc=gnomes@lxorguk.ukuu.org.uk \
--cc=gregkh@linuxfoundation.org \
--cc=hpeter+linux_kernel@gmail.com \
--cc=johan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=peter_hong@fintek.com.tw \
--cc=tom_tsai@fintek.com.tw \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox