From: Beomho Seo <beomho.seo@samsung.com>
To: Sebastian Reichel <sre@kernel.org>
Cc: linux-kernel@vger.kernel.org, linux-pm@vger.kernel.org,
devicetree@vger.kernel.org, robh+dt@kernel.org,
lee.jone@linaro.org, broonie@kernel.org, dbaryshkov@gmail.com,
pawel.moll@arm.com, mark.rutland@arm.com,
ijc+devicetree@hellion.org.uk, galak@codeaurora.org,
cw00.choi@samsung.com, inki.dae@samsung.com,
sw0312.kim@samsung.com, David Woodhouse <dwmw2@infradead.org>
Subject: Re: [PATCH v3 1/2] power: rt5033_charger: Add RT5033 charger device driver
Date: Thu, 22 Jan 2015 12:59:12 +0900 [thread overview]
Message-ID: <54C07590.9080707@samsung.com> (raw)
In-Reply-To: <20150122031240.GA17627@earth.universe>
Thank you for review.
On 01/22/2015 12:12 PM, Sebastian Reichel wrote:
> Hi,
>
> On Thu, Jan 22, 2015 at 09:38:11AM +0900, Beomho Seo wrote:
>> This patch add device driver of Richtek RT5033 PMIC. The driver
>> support switching charger. rt5033 charger provide three charging
>> mode. Three charging mode are pre charge mode, fast cahrge mode
>> and constant voltage mode. They are have vary charge rate, charge
>> parameters. The charge parameters can be controlled by i2c
>> interface.
>>
>> [...]
>>
>> + charger->psy.name = "rt5033-charger",
>> + charger->psy.type = POWER_SUPPLY_TYPE_BATTERY,
>>
>> [...]
>
> POWER_SUPPLY_TYPE_MAINS?
>
> -- Sebastian
>
OK I will change power supply type.
Thanks,
Beomho Seo
next prev parent reply other threads:[~2015-01-22 3:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-01-22 0:38 [PATCH v3 0/2] power: rt5033: Add Richtek RT533 drivers Beomho Seo
2015-01-22 0:38 ` [PATCH v3 1/2] power: rt5033_charger: Add RT5033 charger device driver Beomho Seo
2015-01-22 3:12 ` Sebastian Reichel
2015-01-22 3:59 ` Beomho Seo [this message]
2015-01-22 0:38 ` [PATCH v3 2/2] Documentation: Add documentation for rt5033 multifunction device Beomho Seo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54C07590.9080707@samsung.com \
--to=beomho.seo@samsung.com \
--cc=broonie@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=dbaryshkov@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=dwmw2@infradead.org \
--cc=galak@codeaurora.org \
--cc=ijc+devicetree@hellion.org.uk \
--cc=inki.dae@samsung.com \
--cc=lee.jone@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=robh+dt@kernel.org \
--cc=sre@kernel.org \
--cc=sw0312.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).